New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
re-enable ILB test for VMSS #1177
re-enable ILB test for VMSS #1177
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
2 similar comments
/retest |
/retest |
fix is now in all public cloud regions /hold cancel |
/retest |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CecileRobertMichon The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
01423c2
to
19dc964
Compare
rebased on top of #1186 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
2 similar comments
/retest |
/retest |
/retest |
19dc964
to
d864363
Compare
/retest |
2 similar comments
/retest |
/retest |
This reverts commit c0d8e36.
d864363
to
b999728
Compare
rebased on top of #1197 |
/retest looking into the failure separately
|
@CecileRobertMichon it looks like Windows VMSS is having problems with the LB, but it does look like the cluster provisioned successfully. |
Digging into the error, here are the relevant logs:
So the ILB service got created and deleted successfully but then the ELB service times out. It looks like the LB rules got added successfully but then the Looking at activity logs for the RG I don't see any PUT errors, but I do see a bunch of VMSS writes. @devigned does any of this speak to you? |
Is it possible this is related to the VMSS extension being PUT repeatedly https://kubernetes.slack.com/archives/CEX9HENG7/p1614951175153700?thread_ts=1614873280.120900&cid=CEX9HENG7 |
Yes, I think it might be. I don't see how that would affect the LB reconcile though. The extension should be a no-op... I need to look into it. |
/test pull-cluster-api-provider-azure-e2e-windows |
1 similar comment
/test pull-cluster-api-provider-azure-e2e-windows |
another try just to make sure /test pull-cluster-api-provider-azure-e2e-windows |
/lgtm |
last run failed on the Azure authentication issue, should be fixed now /test pull-cluster-api-provider-azure-e2e |
/test pull-cluster-api-provider-azure-e2e-windows |
This reverts commit c0d8e36.
What type of PR is this?
/kind failing-test
What this PR does / why we need it: Now that the root issue should be fixed in Azure, re-enable the test.
/hold until fix is rolled out to all regions
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #1115
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: