Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs/book/src/developers: fix typo GINKO_FOCUS -> GINKGO_FOCUS #2273

Merged
merged 1 commit into from May 2, 2022
Merged

docs/book/src/developers: fix typo GINKO_FOCUS -> GINKGO_FOCUS #2273

merged 1 commit into from May 2, 2022

Conversation

invidian
Copy link
Member

@invidian invidian commented May 2, 2022

What type of PR is this?
/kind bug

What this PR does / why we need it:

Mentioned environment variable in docs right now is incorrect which made me run entire e2e test suite at least twice 馃ゲ

Release note:

NONE

@invidian
docs/book/src/developers: fix typo GINKO_FOCUS -> GINKGO_FOCUS
3be8f36 
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 2, 2022
mboersma
mboersma approved these changes May 2, 2022
View reviewed changes
Copy link
Contributor

@mboersma mboersma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

Nice catch! I make this mistake all the time, my fingers just don't want to type "ginkgo."

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 2, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mboersma

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 2, 2022
@k8s-ci-robot k8s-ci-robot merged commit f0c71f9 into kubernetes-sigs:main May 2, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.3 milestone May 2, 2022
@invidian invidian deleted the invidian/fix-e2e-gingko-focus-docs branch May 2, 2022 15:28
@invidian
Copy link
Member Author

invidian commented May 2, 2022

Thanks, I appreciate quick merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mboersma mboersma mboersma approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

Assignees

@mboersma mboersma

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@invidian @k8s-ci-robot @mboersma