Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updaete golang.org/x/tools to v0.1.12 #2549

Closed
wants to merge 66 commits into from

Conversation

jackfrancis
Copy link
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR manually updates golang.org/x/tools to v0.1.2 in response to test errors in hack/tools/

Ref: golang/go#49164

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

NONE

Cecile Robert-Michon and others added 30 commits May 4, 2022 23:51
…ot/cherry-pick-2284-to-release-1.3

[release-1.3] Update metadata.yaml to include v1.3 release
…ot/cherry-pick-2297-to-release-1.3

[release-1.3] Upgrade to calico 3.23.0
A customized template can be one on the host or a link.

Signed-off-by: Zhecheng Li <zhechengli@microsoft.com>
…ot/cherry-pick-2214-to-release-1.3

[release-1.3] Use MSI ClientID as userAssignedIdentityID in azure.json
[release-1.3] Support using a customized template outside CAPZ repo
…ot/cherry-pick-2261-to-release-1.3

[release-1.3] test: fix wait.PollImmediate so it actually retries after errors
…ot/cherry-pick-2304-to-release-1.3

[release-1.3] Fix apiserver cloud-provider arg for external cloud-provider template
…2316

[release-1.3] ci: support external-cloud-provider plus latest k8s rel…
…er-template-prow-ci-version templates

Signed-off-by: Mark Rossetti <marosset@microsoft.com>
…ot/cherry-pick-2350-to-release-1.3

[release-1.3] ci: fixing issue where WINDOWS_SERVER_VERSION does not work for cluster-template-prow-ci-version templates
…ot/cherry-pick-2353-to-release-1.3

[release-1.3] use capi v1.1.4
To allow access to CommunityGalleryImageID field in ImageReference.

Refs kubernetes-sigs#2267

Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
Signed-off-by: Mateusz Gozdek <mgozdek@microsoft.com>
…ot/cherry-pick-2362-to-release-1.3

[release-1.3] Stop testing upgrade from v1alpha3 in e2e
…ot/cherry-pick-2325-to-release-1.3

[release-1.3] simplify ci-entrypoint.sh
…2346-release-1.3

[release-1.3] Fix KUBERNETES_VERSION unset if CLUSTER_TEMPLATE set
…ot/cherry-pick-2288-to-release-1.3

[release-1.3] Update to compute API 2021-11-01
…ot/cherry-pick-2302-to-release-1.3

[release-1.3] Use new naming scheme for SKUs and versions
mboersma and others added 18 commits June 27, 2022 07:53
…ot/cherry-pick-2356-to-release-1.3

[release-1.3] Use "registry.k8s.io" for Kubernetes artifacts
…ot/cherry-pick-2398-to-release-1.3

[release-1.3] fix: tag images when using latest
…ot/cherry-pick-2388-to-release-1.3

[release-1.3] Find current Kubernetes versions for e2e testing
Co-Authored-By: Mark Rossetti <18291632+marosset@users.noreply.github.com>
…ot/cherry-pick-2462-to-release-1.3

[release-1.3] Fix Cluster labels in OOT cloud provider templates
…ot/cherry-pick-2474-to-release-1.3

[release-1.3] Add gingko conformance timeout
…ot/cherry-pick-2489-to-release-1.3

[release-1.3] Check for nil infra ref in azurejson controllers
…ot/cherry-pick-2425-to-release-1.3

[release-1.3] Switching from strings.Title to cases.Title
…ot/cherry-pick-2536-to-release-1.3

[release-1.3] enforce lowercase providerID RG to match cloud-provider-azure
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Aug 11, 2022
@k8s-ci-robot
Copy link
Contributor

@jackfrancis: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 11, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jackfrancis by writing /assign @jackfrancis in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

@jackfrancis: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-azure-e2e-exp 8521248 link false /test pull-cluster-api-provider-azure-e2e-exp
pull-cluster-api-provider-azure-build 8521248 link true /test pull-cluster-api-provider-azure-build
pull-cluster-api-provider-azure-verify 8521248 link true /test pull-cluster-api-provider-azure-verify
pull-cluster-api-provider-azure-apidiff 8521248 link false /test pull-cluster-api-provider-azure-apidiff
pull-cluster-api-provider-azure-ci-entrypoint 8521248 link true /test pull-cluster-api-provider-azure-ci-entrypoint
pull-cluster-api-provider-azure-e2e 8521248 link true /test pull-cluster-api-provider-azure-e2e
pull-cluster-api-provider-azure-test 8521248 link true /test pull-cluster-api-provider-azure-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jackfrancis jackfrancis deleted the go-tools-go-mod branch December 9, 2022 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants