-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Use clusterctl move annotation on last systempool validation" #4387
Revert "Use clusterctl move annotation on last systempool validation" #4387
Conversation
This reverts commit cf10241.
/cherry-pick release-1.12 |
@CecileRobertMichon: once the present PR merges, I will cherry-pick it on top of release-1.12 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
LGTM label has been added. Git tree hash: f997f51bdceb3a9d850e3d6e9509fc1850c5fa05
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mboersma The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #4387 +/- ##
=======================================
Coverage 60.95% 60.95%
=======================================
Files 190 190
Lines 18993 18993
=======================================
Hits 11578 11578
Misses 6783 6783
Partials 632 632 ☔ View full report in Codecov by Sentry. |
@CecileRobertMichon: new pull request created: #4389 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind bug
What this PR does / why we need it:
clusterctlv1.DeleteForMoveAnnotation
on last systempool validation #3426api/v1beta1/azuremanagedmachinepool_webhook.go
will useownerCluster.Spec.Paused
while performing clusterctl move.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Temporarily unblocks users facing #4341
Special notes for your reviewer:
TODOs:
Release note: