Check UserManaged is not nil in azure/converters/diagnostics

[Patryk-Stefanski]

What this PR does / why we need it: Adds nil check for UserManagedDiagnosticsStorage in azure/converters/diagnostics.go . This prevents a crash in the case that the StorageAccountURI provided is empty.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

• cherry-pick candidate

TODOs:

• squashed commits
• includes documentation
• adds unit tests

Release note:

Adds nil check for UserManagedDiagnosticsStorage in azure/converters/diagnostics.go 

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: Patryk-Stefanski / name: Patryk Stefanski (d8f1e9d)

[k8s-ci-robot]

Welcome @Patryk-Stefanski!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-azure 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-azure has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[k8s-ci-robot]

Hi @Patryk-Stefanski. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[Patryk-Stefanski]

/kind bug

[enxebre]

/ok-to-test

[enxebre]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 2d5a49dd2b6615d2ee8c41c705b264908af0f80f

[jackfrancis]

can we add a new UT case "nil diagnostics.Boot.UserManaged" to the TestGetDiagnosticsProfile spec under azure/converters/diagnostics_test.go?

[jackfrancis]

thank you!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.01%. Comparing base (d817ab3) to head (d8f1e9d).
Report is 65 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4819      +/-   ##
==========================================
- Coverage   62.48%   62.01%   -0.47%     
==========================================
  Files         196      201       +5     
  Lines       16188    16858     +670     
==========================================
+ Hits        10115    10455     +340     
- Misses       5333     5620     +287     
- Partials      740      783      +43     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[mboersma]

/assign @jackfrancis

[nojnhuh]

@Patryk-Stefanski Please squash your commits when you've gotten LGTM. Thanks!
/hold

[jackfrancis]

/lgtm

[k8s-ci-robot]

LGTM label has been added.

Git tree hash: 28f27fc96f836c5a8a484e572caab4ef95a5033b

[nojnhuh]

Thank you for squashing!
/hold cancel

[nojnhuh]

/lgtm
/approve
/cherry-pick release-1.14
/cherry-pick release-1.15

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [nojnhuh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jackfrancis]

/retest

[nojnhuh]

/retest