Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add kubeadm configs, load balancer, public IP, refactor actuators, types #88

Merged
merged 8 commits into from
Feb 26, 2019
Merged

Add kubeadm configs, load balancer, public IP, refactor actuators, types #88

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
88e4209
Fix dependencies
justaugustus Jan 31, 2019
5235009
Add annotation to machine `Create` to satisfy `waitForMachineReady`
justaugustus Feb 1, 2019
08a77ae
Refactor actuator methods, update types, regenerate manifests
justaugustus Feb 2, 2019
83ec03f
Update Deployments logic and startup scripts
justaugustus Feb 24, 2019
a7483ec
Update image tag
justaugustus Feb 24, 2019
1c35bb7
Update LB and Public IP logic
justaugustus Feb 19, 2019
6bb758a
Update vm configurations
justaugustus Feb 25, 2019
6436ff4
Update method comments, copyrights, remove deployment-params.json
justaugustus Feb 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ COPY vendor/ vendor/
RUN CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -a -o manager sigs.k8s.io/cluster-api-provider-azure/cmd/manager

# Copy the controller-manager into a thin image
FROM alpine:3.8
FROM alpine:3.9
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CAPI uses gcr.io/distroless/static:latest, an example is here, the binary has to be built as a static one though.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vincepri! I've added an item here to take a look at that as a follow-up.

WORKDIR /root/
COPY --from=builder /go/src/sigs.k8s.io/cluster-api-provider-azure/manager .
COPY --from=builder /go/src/sigs.k8s.io/cluster-api-provider-azure/pkg/cloud/azure/services/resources/template/deployment-template.json .
Expand Down
Loading