New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make error handling consistent for the remaining packages #127
Make error handling consistent for the remaining packages #127
Conversation
Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA. It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Hi @solidnerd. Thanks for your PR. I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cd76d4b
to
6ea6cae
Compare
/check-cla |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making it consistent! 😄 🎉
/lgtm
/approve
/ok-to-test |
Oh yeah, @xmudrii mentioned that #126 is required for tests to pass. @solidnerd This should get merged once #126 is merged. ✅ |
@nikhita thanks for reviewing this. Yeah it's okay it doesn't stress me 😄 . |
@solidnerd Thanks for the PR! The reason why this particular test is failing is because gofmt is failing on some package. If you run gofmt and push a fix, tests should start passing again regardless of #126. However, I would put this on hold until #126 is not merged if you don't mind. It's a huge PR and currently in review phase, so I would like first to get done with that one and then get back to merging other PRs. /hold |
The PR #126 is now merged, so I'm going to remove hold from this PR. @solidnerd Once the fmt error is fixed I'll be happy to merge this PR :) |
Bumping this. @solidnerd do you think you can get to the fmt error soon? we could merge this after that :) |
6ea6cae
to
dbd1356
Compare
@nikhita done ;) |
Thanks! /lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: nikhita, solidnerd, xmudrii The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Signed-off-by: solidnerd niclas@mietz.io
What this PR does / why we need it:
This will resolve a part of #109 and will format the last errors without values.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Partly #109