Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make error handling consistent for the remaining packages #127

Conversation

solidnerd
Copy link
Contributor

Signed-off-by: solidnerd niclas@mietz.io

What this PR does / why we need it:

This will resolve a part of #109 and will format the last errors without values.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Partly #109

@k8s-ci-robot
Copy link

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.


Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Jan 4, 2019
@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 4, 2019
@k8s-ci-robot
Copy link

Hi @solidnerd. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 4, 2019
@solidnerd solidnerd force-pushed the make-error-handling-consistent branch 3 times, most recently from cd76d4b to 6ea6cae Compare January 4, 2019 11:18
@solidnerd
Copy link
Contributor Author

/check-cla

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Jan 9, 2019
Copy link
Member

@nikhita nikhita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making it consistent! 😄 🎉

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jan 9, 2019
@nikhita
Copy link
Member

nikhita commented Jan 9, 2019

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2019
@nikhita
Copy link
Member

nikhita commented Jan 9, 2019

Oh yeah, @xmudrii mentioned that #126 is required for tests to pass.

@solidnerd This should get merged once #126 is merged. ✅

@solidnerd
Copy link
Contributor Author

@nikhita thanks for reviewing this. Yeah it's okay it doesn't stress me 😄 .

@xmudrii
Copy link
Member

xmudrii commented Jan 10, 2019

@solidnerd Thanks for the PR! The reason why this particular test is failing is because gofmt is failing on some package. If you run gofmt and push a fix, tests should start passing again regardless of #126.

However, I would put this on hold until #126 is not merged if you don't mind. It's a huge PR and currently in review phase, so I would like first to get done with that one and then get back to merging other PRs.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2019
@xmudrii
Copy link
Member

xmudrii commented Feb 7, 2019

The PR #126 is now merged, so I'm going to remove hold from this PR.
/hold cancel

@solidnerd Once the fmt error is fixed I'll be happy to merge this PR :)

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 7, 2019
@nikhita
Copy link
Member

nikhita commented Mar 7, 2019

Bumping this.

@solidnerd do you think you can get to the fmt error soon? we could merge this after that :)

@solidnerd solidnerd force-pushed the make-error-handling-consistent branch from 6ea6cae to dbd1356 Compare March 7, 2019 18:49
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2019
@solidnerd
Copy link
Contributor Author

@nikhita done ;)

@xmudrii
Copy link
Member

xmudrii commented Mar 7, 2019

Thanks!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 7, 2019
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, solidnerd, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2e16419 into kubernetes-sigs:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants