Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial e2e-test #148

Merged
merged 1 commit into from
Mar 31, 2020
Merged

Initial e2e-test #148

merged 1 commit into from
Mar 31, 2020

Conversation

prksu
Copy link
Contributor

@prksu prksu commented Mar 28, 2020 •
edited
Loading

What this PR does / why we need it:
This PR add e2e test by creating and deleting a single controlplane and one worker cluster. both controlplane and worker created using machine api.

So in this PR doesn't cover the machine deployment api maybe we can add machine deployment e2e test in the followup

Fixes #121

Special notes for your reviewer:

Documentation:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 28, 2020
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: prksu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Mar 28, 2020
@prksu prksu changed the title WIP: Initial e2e-test Initial e2e-test Mar 29, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 29, 2020
@prksu
Copy link
Contributor Author

prksu commented Mar 29, 2020

/assign @cpanato

prksu
prksu commented Mar 29, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
prksu
prksu commented Mar 29, 2020
View reviewed changes
Makefile Outdated Show resolved Hide resolved
xmudrii
xmudrii reviewed Mar 29, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did an initial review and left some nits. Otherwise, I think the PR looks great.

Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
test/e2e/README.md Outdated Show resolved Hide resolved
@cpanato
Copy link
Member

cpanato commented Mar 31, 2020

@prksu @xmudrii what do we need to add/create to make this run? this thing is new to me but i can work to get that done

@xmudrii
Copy link
Member

xmudrii commented Mar 31, 2020

@cpanato I'm not sure what do you mean by make this run. Do you mean that we have this as a presubmit or something else?

@cpanato
Copy link
Member

cpanato commented Mar 31, 2020

@xmudrii lets chat over slack :)

cpanato
cpanato approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold for @xmudrii review

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Mar 31, 2020
xmudrii
xmudrii approved these changes Mar 31, 2020
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 31, 2020
@k8s-ci-robot k8s-ci-robot merged commit 428a397 into kubernetes-sigs:master Mar 31, 2020
@prksu prksu deleted the initial-e2e-test branch March 31, 2020 12:16
@prksu prksu mentioned this pull request Apr 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@xmudrii xmudrii xmudrii approved these changes

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@cpanato cpanato

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add prowjob for e2e test
4 participants
@prksu @k8s-ci-robot @cpanato @xmudrii