Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capi: using released artifacts #260

Merged
merged 1 commit into from
Jun 10, 2021
Merged

capi: using released artifacts #260

merged 1 commit into from
Jun 10, 2021

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jun 10, 2021

What this PR does / why we need it:
Using the release CAPI artifacts, the images was not published so that was failing, now it is live and we can use the released artifacts

/assign @prksu @timoreimann @MorrisLaw

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Documentation:

Release note:

NONE

Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Jun 10, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jun 10, 2021
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jun 10, 2021
@prksu
Copy link
Contributor

prksu commented Jun 10, 2021

/test ?

@k8s-ci-robot
Copy link

@prksu: The following commands are available to trigger jobs:

  • /test pull-cluster-api-provider-digitalocean-test
  • /test pull-cluster-api-provider-digitalocean-build
  • /test pull-cluster-api-provider-digitalocean-verify
  • /test pull-cluster-api-provider-digitalocean-lint
  • /test pull-cluster-api-provider-digitalocean-e2e
  • /test pull-cluster-api-provider-digitalocean-capi-e2e
  • /test pull-cluster-api-provider-digitalocean-conformance

Use /test all to run the following jobs:

  • pull-cluster-api-provider-digitalocean-test
  • pull-cluster-api-provider-digitalocean-build
  • pull-cluster-api-provider-digitalocean-verify
  • pull-cluster-api-provider-digitalocean-lint
  • pull-cluster-api-provider-digitalocean-e2e

In response to this:

/test ?

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@prksu
Copy link
Contributor

prksu commented Jun 10, 2021

/test pull-cluster-api-provider-digitalocean-capi-e2e

@k8s-ci-robot
Copy link

@cpanato: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-cluster-api-provider-digitalocean-capi-e2e f09576f link /test pull-cluster-api-provider-digitalocean-capi-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Copy link
Contributor

@prksu prksu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seem these changes broke our capi-e2e test.

never mind, capi-e2e test is an optional test.
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 10, 2021
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, prksu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit c5a5f06 into kubernetes-sigs:master Jun 10, 2021
@cpanato cpanato deleted the use-capi-release branch June 10, 2021 12:33
@cpanato
Copy link
Member Author

cpanato commented Jun 10, 2021

let me follow up on that, will open a new PR to check this

@cpanato
Copy link
Member Author

cpanato commented Jun 10, 2021

ahh this is the capi test, will check that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants