Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add pause annotation check #300

Merged
merged 3 commits into from Feb 16, 2022
Merged

add pause annotation check #300

merged 3 commits into from Feb 16, 2022

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Feb 15, 2022

What this PR does / why we need it:
/kind feature

  • fix ldflags when building the image
  • update create kind script
  • add check for pause annotation

the check for the pause annotation is needed for some clusterctl operations like move/backup

/hold for non required tests
/assign @timoreimann @MorrisLaw @prksu

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Documentation:

Release note:

add pause annotation check

@cpanato
fix ldflags when building the image
27c34b9 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato
update create kind script
346c69f 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@cpanato
add check for pause annotation
7a51676 
Signed-off-by: Carlos Panato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2022
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. labels Feb 15, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 15, 2022
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 15, 2022
@cpanato
Copy link
Member Author

cpanato commented Feb 15, 2022

/test ls

@k8s-ci-robot
Copy link

@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-digitalocean-build
  • /test pull-cluster-api-provider-digitalocean-e2e
  • /test pull-cluster-api-provider-digitalocean-lint
  • /test pull-cluster-api-provider-digitalocean-test
  • /test pull-cluster-api-provider-digitalocean-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-digitalocean-capi-e2e
  • /test pull-cluster-api-provider-digitalocean-capi-e2e-experimental
  • /test pull-cluster-api-provider-digitalocean-conformance

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-digitalocean-build
  • pull-cluster-api-provider-digitalocean-e2e
  • pull-cluster-api-provider-digitalocean-lint
  • pull-cluster-api-provider-digitalocean-test
  • pull-cluster-api-provider-digitalocean-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member Author

cpanato commented Feb 15, 2022

/test pull-cluster-api-provider-digitalocean-capi-e2e
/test pull-cluster-api-provider-digitalocean-conformance

@cpanato
Copy link
Member Author

cpanato commented Feb 15, 2022

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 15, 2022
@timoreimann
Copy link
Contributor

Really useful to have this one.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 16, 2022
@k8s-ci-robot k8s-ci-robot merged commit 6a58ece into kubernetes-sigs:main Feb 16, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Feb 16, 2022
@cpanato cpanato deleted the pause branch February 16, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chuckha chuckha Awaiting requested review from chuckha

@detiber detiber Awaiting requested review from detiber

Assignees

@timoreimann timoreimann

@MorrisLaw MorrisLaw

@prksu prksu

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cpanato @k8s-ci-robot @timoreimann @MorrisLaw @prksu