Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add volumes field to DOMachine status #404

Merged
merged 4 commits into from Oct 8, 2022
Merged

Add volumes field to DOMachine status #404

merged 4 commits into from Oct 8, 2022

Conversation

gottwald
Copy link
Contributor

@gottwald gottwald commented Oct 7, 2022

What this PR does / why we need it:

This will help when debugging because it's easier to find the associated volume that was provisioned with the droplet.

Release note:

Add associated volumes to DOMachine status

@gottwald
Add volumes field to DOMachineStatus
96a2086 
This will help when debugging because it's easier to find the associated volume
that was provisioned with the droplet.
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 7, 2022
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 7, 2022
@k8s-ci-robot
Copy link

Hi @gottwald. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 7, 2022
timoreimann
timoreimann reviewed Oct 7, 2022
View reviewed changes
api/v1alpha3/types.go Outdated Show resolved Hide resolved
cloud/scope/machine.go Outdated Show resolved Hide resolved
@gottwald
Fix typos
184106b
@gottwald
Simplify SetVolumes
641c44e 
This makes also sure that volume IDs would be removed which practically
shouldn't happen.
MorrisLaw
MorrisLaw requested changes Oct 8, 2022
View reviewed changes
Copy link
Member

@MorrisLaw MorrisLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo nits

config/crd/bases/infrastructure.cluster.x-k8s.io_domachines.yaml Outdated Show resolved Hide resolved
config/crd/bases/infrastructure.cluster.x-k8s.io_domachines.yaml Outdated Show resolved Hide resolved
@MorrisLaw MorrisLaw added the hacktoberfest Indicates that a PR/Issue should be counted for Hacktoberfest. label Oct 8, 2022
@gottwald gottwald requested review from MorrisLaw and removed request for sbueringer October 8, 2022 05:52
MorrisLaw
MorrisLaw approved these changes Oct 8, 2022
View reviewed changes
Copy link
Member

@MorrisLaw MorrisLaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 8, 2022
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gottwald, MorrisLaw

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 8, 2022
@MorrisLaw
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 8, 2022
@k8s-ci-robot k8s-ci-robot merged commit 01b1d44 into kubernetes-sigs:main Oct 8, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Oct 8, 2022
@gottwald gottwald mentioned this pull request Oct 27, 2022
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timoreimann timoreimann timoreimann left review comments

@MorrisLaw MorrisLaw MorrisLaw approved these changes

Assignees

@MorrisLaw MorrisLaw

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. hacktoberfest Indicates that a PR/Issue should be counted for Hacktoberfest. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gottwald @k8s-ci-robot @MorrisLaw @timoreimann