Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update dependencies and CAPI to 1.5 #527

Merged
merged 11 commits into from Oct 30, 2023
Merged

Update dependencies and CAPI to 1.5 #527

merged 11 commits into from Oct 30, 2023

Conversation

llDrLove
Copy link
Contributor

@llDrLove llDrLove commented Oct 5, 2023 •
edited

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):

  • Upgrade Kubernetes packages to 0.27.6
  • Upgrade controller-runtime to v0.15.2
  • Upgrade cluster-api to v1.4.5
  • Upgrade CAPI to 1.4.5

Special notes for your reviewer:
NONE

Documentation:

NONE

Release note:

Upgrade Kubernetes packages to 0.27.6
Upgrade controller-runtime to v0.15.2
Upgrade cluster-api to v1.5.2
Upgrade CAPI to 1.5.2

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 5, 2023
@k8s-ci-robot
Copy link

Hi @llDrLove. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 5, 2023
@timoreimann
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 6, 2023
@llDrLove llDrLove changed the title [WIP] capi 1.5 k8s 1.27 Update dependencies and CAPI to 1.5 Oct 6, 2023
@llDrLove
Copy link
Contributor Author

llDrLove commented Oct 6, 2023

/retest

1 similar comment
@llDrLove
Copy link
Contributor Author

llDrLove commented Oct 6, 2023

/retest

@llDrLove llDrLove marked this pull request as ready for review October 6, 2023 22:15
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 6, 2023
@cpanato
Copy link
Member

cpanato commented Oct 27, 2023

@llDrLove can you please rebase?

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2023
@llDrLove
Copy link
Contributor Author

@cpanato , I've rebased.

@cpanato
Copy link
Member

cpanato commented Oct 30, 2023

/test ls

@k8s-ci-robot
Copy link

@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-digitalocean-build
  • /test pull-cluster-api-provider-digitalocean-e2e
  • /test pull-cluster-api-provider-digitalocean-test
  • /test pull-cluster-api-provider-digitalocean-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-digitalocean-capi-e2e
  • /test pull-cluster-api-provider-digitalocean-capi-e2e-experimental
  • /test pull-cluster-api-provider-digitalocean-conformance
  • /test pull-cluster-api-provider-digitalocean-conformance-ci-artifacts
  • /test pull-cluster-api-provider-digitalocean-e2e-workload-upgrade

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-digitalocean-build
  • pull-cluster-api-provider-digitalocean-e2e
  • pull-cluster-api-provider-digitalocean-test
  • pull-cluster-api-provider-digitalocean-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
Copy link
Member

cpanato commented Oct 30, 2023

/test pull-cluster-api-provider-digitalocean-capi-e2e
/test pull-cluster-api-provider-digitalocean-conformance

cpanato
cpanato approved these changes Oct 30, 2023
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool
thank you!
/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 30, 2023
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, llDrLove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Oct 30, 2023
@k8s-ci-robot k8s-ci-robot merged commit fc6b6c3 into kubernetes-sigs:main Oct 30, 2023
9 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@llDrLove @k8s-ci-robot @timoreimann @cpanato