Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates for lint job and Go for the image #533

Merged
merged 3 commits into from Oct 11, 2023
Merged

Updates for lint job and Go for the image #533

merged 3 commits into from Oct 11, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Oct 11, 2023

What this PR does / why we need it:

  • Updates for lint job and Go for the image

/kind feature

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Documentation:

Release note:

Updates for lint job and Go for the image

@cpanato
update lint job
bbaeddb 
Signed-off-by: cpanato <ctadeu@gmail.com>
@cpanato
update go to 1.20.10
40a904d 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 11, 2023
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2023
@cpanato
Copy link
Member Author

cpanato commented Oct 11, 2023

/test ls

@k8s-ci-robot
Copy link

@cpanato: The specified target(s) for /test were not found.
The following commands are available to trigger required jobs:

  • /test pull-cluster-api-provider-digitalocean-build
  • /test pull-cluster-api-provider-digitalocean-e2e
  • /test pull-cluster-api-provider-digitalocean-test
  • /test pull-cluster-api-provider-digitalocean-verify

The following commands are available to trigger optional jobs:

  • /test pull-cluster-api-provider-digitalocean-capi-e2e
  • /test pull-cluster-api-provider-digitalocean-capi-e2e-experimental
  • /test pull-cluster-api-provider-digitalocean-conformance
  • /test pull-cluster-api-provider-digitalocean-conformance-ci-artifacts
  • /test pull-cluster-api-provider-digitalocean-e2e-workload-upgrade

Use /test all to run the following jobs that were automatically triggered:

  • pull-cluster-api-provider-digitalocean-build
  • pull-cluster-api-provider-digitalocean-e2e
  • pull-cluster-api-provider-digitalocean-test
  • pull-cluster-api-provider-digitalocean-verify

In response to this:

/test ls

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@cpanato
ignore lints
d76f304 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 11, 2023
@cpanato
Copy link
Member Author

cpanato commented Oct 11, 2023

/test pull-cluster-api-provider-digitalocean-conformance-ci-artifacts

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 11, 2023
@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, gottwald

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 3456587 into kubernetes-sigs:main Oct 11, 2023
8 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.1.0 milestone Oct 11, 2023
@cpanato cpanato deleted the updates branch October 12, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gottwald gottwald gottwald approved these changes

@enxebre enxebre Awaiting requested review from enxebre

@vincepri vincepri Awaiting requested review from vincepri

Assignees

@gottwald gottwald

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cpanato @k8s-ci-robot @gottwald