This repository has been archived by the owner on Sep 24, 2021. It is now read-only.
Implement version info into binaries #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
Closed
ashish-amarnath
commented
Jul 17, 2019
chuckha
reviewed
Jul 17, 2019
|
From the version thingy I did for capa.. 😂
…On Wed, Jul 17, 2019 at 7:37 AM Chuck Ha ***@***.***> wrote:
***@***.**** commented on this pull request.
This looks solid, one comment that i'm fine punting on since copy pasta is
not that bad. Out of curiosity did you copy/pasta the Version file and if
so from where? I am pretty sure I've seen this code before somewhere
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#89>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFOQASTCNG6VXCRIDG3772TP74VBXANCNFSM4IENPCZA>
.
|
|
/approve /assign @liztio |
k8s-ci-robot
added
the
approved
chuckha
reviewed
Jul 17, 2019
chuckha
reviewed
Jul 17, 2019
|
just a few more comments |
k8s-ci-robot
added
the
needs-rebase
ashish-amarnath
force-pushed
the
capdctl-version
branch
from
cb5d04b
to
1b4c307
Compare
k8s-ci-robot
removed
the
needs-rebase
chuckha
reviewed
Jul 18, 2019
|
after those changes and squashing commits, i think this looks good |
ashish-amarnath
force-pushed
the
capdctl-version
branch
from
9b2c567
to
19345b7
Compare
k8s-ci-robot
added
the
needs-rebase
add script to set workspace status implement version subcommand for capdctl add script to build binaries implement versioninfo as a package build capd-manager with version info build kind-test with version info update readme Signed-off-by: Ashish Amarnath <ashish.amarnath@gmail.com>
ashish-amarnath
force-pushed
the
capdctl-version
branch
from
19345b7
to
55c2e59
Compare
k8s-ci-robot
removed
the
needs-rebase
ashish-amarnath
changed the title
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashish-amarnath, chuckha The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Improves debug-ability of capd by printing version info of various
capdbinariesWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
Release note: