Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[release-1.6] Bump setup-envtest to use new controller-tools binaries #1253

Merged
merged 1 commit into from
Jun 4, 2024
Merged

[release-1.6] Bump setup-envtest to use new controller-tools binaries #1253

merged 1 commit into from
Jun 4, 2024

Conversation

damdo
Copy link
Member

@damdo damdo commented Jun 4, 2024

Bump setup-envtest to use new controller-tools binaries

What type of PR is this?

/kind cleanup

Release note:

NONE

@damdo
bump: setup-envtest
7ca6122 
This is a commit from CR main (22.05.2024).
Intentionally using a commit from main to use a setup-envtest version
that uses binaries from controller-tools, not GCS.
CR PR: kubernetes-sigs/controller-runtime#2811
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jun 4, 2024
@k8s-ci-robot k8s-ci-robot requested review from cpanato and dims June 4, 2024 12:41
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jun 4, 2024
@damdo damdo mentioned this pull request Jun 4, 2024
Closed
@damdo
Copy link
Member Author

damdo commented Jun 4, 2024

/assign @cpanato

cpanato
cpanato approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 4, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2024
@k8s-ci-robot k8s-ci-robot merged commit 118def8 into kubernetes-sigs:release-1.6 Jun 4, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpanato cpanato cpanato approved these changes

@dims dims Awaiting requested review from dims

Assignees

@cpanato cpanato

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@damdo @k8s-ci-robot @cpanato