Adding e2e tests for shared vpc installs #1255
Conversation
k8s-ci-robot
added
kind/feature
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: barbacbd The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
needs-ok-to-test
|
Hi @barbacbd. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
✅ Deploy Preview for kubernetes-sigs-cluster-api-gcp ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
size/L
barbacbd
force-pushed
the
add-shared-vpc-e2e-tests
branch
from
671dca4
to
d221164
Compare
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
barbacbd
force-pushed
the
add-shared-vpc-e2e-tests
branch
from
d221164
to
3c5e5b0
Compare
| | bash) || true | ||
| gcloud compute networks delete --project="${GCP_PROJECT}" \ | ||
| --quiet "${GCP_NETWORK_NAME}" || true | ||
| fi |
There was a problem hiding this comment.
The GCP_SERVICE_PROJECT is where a lot of these resources such as image will be created during a shared vpc install. Trying to think of a way to incorporate that here on cleanup.
| @@ -102,6 +102,9 @@ EOF | |||
|
|
|||
| # initialize a router and cloud NAT | |||
| init_networks() { | |||
| # gcloud compute shared-vpc enable "$GCP_PROJECT" | |||
There was a problem hiding this comment.
These actions require more permissions. We either need to allow this permission, setup a specific project just for this e2e test, or use the same project (which wont be a shared vpc install). Any ideas @damdo ?
There was a problem hiding this comment.
Not sure what's best here. @cpanato did this ever come up in the past?
There was a problem hiding this comment.
if need another project to run together, i would suggest to we talk with sig-testing/sig-infra to see if that is possible when running the prow job
k8s-ci-robot
added
ok-to-test
|
@barbacbd: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
This PR is opened to add e2e tests for the feature shared vpcs.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Updates ##1189
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: