-
Notifications
You must be signed in to change notification settings - Fork 189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allows using a local image in make create-cluster #432
Conversation
…push the dev image out to a registry.
Hi @sayantani11. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/ok-to-test |
@cpanato I tried using GPG key, but I am kind of unsure about it. If possible can I replace it with SSH Key? Or should we remove this part? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for this
but what is the difference between using this and using the tilt config we have? seems similar
Its makes it convenient so we could use a local image, else we would require to push the dev image to a registry first. Just to make the experience better. Like done in capz, trying to bring capg on the same page: kubernetes-sigs/cluster-api-provider-azure#471 |
/retest |
What type of PR is this?
What this PR does / why we need it:
Allows using a local image in
make create-cluster
to avoid having to push the dev image out to a registryWhich issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.
TODOs:
Release note: