Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ginkgo / gomega #46

Merged
merged 1 commit into from Oct 18, 2018

Conversation

roberthbailey
Copy link
Contributor

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #44

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 16, 2018
@roberthbailey
Copy link
Contributor Author

/assign @krousey

@k8s-ci-robot
Copy link
Contributor

@roberthbailey: GitHub didn't allow me to assign the following users: krousey.

Note that only kubernetes-sigs members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @krousey

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roberthbailey
Copy link
Contributor Author

/assign @justinsb

@krousey
Copy link
Contributor

krousey commented Oct 16, 2018

/lgtm

and thank you

@k8s-ci-robot
Copy link
Contributor

@krousey: changing LGTM is restricted to assignees, and only kubernetes-sigs/cluster-api-provider-gcp repo collaborators may be assigned issues.

In response to this:

/lgtm

and thank you

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roberthbailey
Copy link
Contributor Author

@lucasnorman - sorry I didn't see your PR. There is a similar bug open in the main cluster-api repo (which I won't have time to address soon) if you want to take a look at starting to pull out ginkgo there.

@justinsb
Copy link
Contributor

/lgtm

Expect(gomega).NotTo(HaveOccurred()) :-)

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit c6fbd19 into kubernetes-sigs:master Oct 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove ginkgo code (introduced by kubebuilder migration)
4 participants