New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove ginkgo / gomega #46
Remove ginkgo / gomega #46
Conversation
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: roberthbailey The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @krousey |
@roberthbailey: GitHub didn't allow me to assign the following users: krousey. Note that only kubernetes-sigs members and repo collaborators can be assigned. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @justinsb |
/lgtm and thank you |
@krousey: changing LGTM is restricted to assignees, and only kubernetes-sigs/cluster-api-provider-gcp repo collaborators may be assigned issues. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@lucasnorman - sorry I didn't see your PR. There is a similar bug open in the main cluster-api repo (which I won't have time to address soon) if you want to take a look at starting to pull out ginkgo there. |
/lgtm
|
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #44
Special notes for your reviewer:
Release note: