Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Cluster template for ipv6 #471

Closed
wants to merge 2 commits into from
Closed

[WIP] Cluster template for ipv6 #471

wants to merge 2 commits into from

Conversation

sayantani11
Copy link
Contributor

What type of PR is this?

What this PR does / why we need it:
This PR adds a cluster template with ipv6.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #
A part of #451

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • includes documentation
  • adds unit tests

Release note:

Cluster template with ipv6

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Dec 8, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign rsmitty after the PR has been reviewed.
You can assign the PR to them by writing /assign @rsmitty in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Dec 8, 2021
stmcginnis and others added 2 commits December 8, 2021 19:09
@stmcginnis @sayantani11
Bump golangci-lint to 1.43.0
ade4789 
This version pulls in updated linters. This provides better checks and
addresses an issue some had when running under go 1.17.

Signed-off-by: Sean McGinnis <sean.mcginnis@gmail.com>
@sayantani11
Cluster template for ipv6
9509709
@sayantani11 sayantani11 closed this Dec 8, 2021
@sayantani11 sayantani11 deleted the ipv6 branch December 8, 2021 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CecileRobertMichon CecileRobertMichon Awaiting requested review from CecileRobertMichon

@detiber detiber Awaiting requested review from detiber

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@sayantani11 @k8s-ci-robot @stmcginnis