Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

State explicitly K8s version to be used in bootstrap cluster. #65

Merged
merged 1 commit into from
Nov 30, 2018
Merged

State explicitly K8s version to be used in bootstrap cluster. #65

merged 1 commit into from
Nov 30, 2018

Conversation

oxddr
Copy link
Contributor

@oxddr oxddr commented Nov 30, 2018

State explicitly K8s version to be used in bootstrap cluster, to make the clusterctl command working with various versions of minikube. Kubernetes before v1.12 doesn't support sub-resources in CRDs.

Also ignore kubeconfig file generated by clusterctl.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #59

@oxddr
State explicitly K8s version to be used in bootstrap cluster.
529bf2f 
Kubernetes before v1.12 doesn't support sub-resources in CRDs.

Also ignore kubeconfig file generated by clusterctl.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Nov 30, 2018
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 30, 2018
@k8s-ci-robot
Copy link
Contributor

Hi @oxddr. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@roberthbailey
Copy link
Contributor

/ok-to-test
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 30, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oxddr, roberthbailey

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 30, 2018
@k8s-ci-robot k8s-ci-robot merged commit bbcdb16 into kubernetes-sigs:master Nov 30, 2018
@oxddr oxddr mentioned this pull request Jun 6, 2019
Closed
6 tasks
yuecong added a commit to yuecong/cluster-api-provider-gcp-oss that referenced this pull request Aug 15, 2023
@yuecong
Support master authorized network config (kubernetes-sigs#65)
15805f8 
* add MasterAuthorizedNetworksConfig filed into GCPManagedControlPlane CRD

* fix

* disable it if no desired specified in CR

* change to do not reconcile if the desired CR is nil

* add comment
yuecong added a commit to yuecong/cluster-api-provider-gcp-oss that referenced this pull request Aug 31, 2023
@yuecong
Support master authorized network config (kubernetes-sigs#65)
682457a 
* add MasterAuthorizedNetworksConfig filed into GCPManagedControlPlane CRD

* fix

* disable it if no desired specified in CR

* change to do not reconcile if the desired CR is nil

* add comment

add nil handling fo GcpPublicCidrsAccessEnabled

change nil as enabled

fix display_name not to be optional

address comments

fix typo and remove empty line
richardchen-db pushed a commit to databricks/cluster-api-provider-gcp-1 that referenced this pull request Oct 5, 2023
@yuecong @richardchen-db
Support master authorized network config (kubernetes-sigs#65)
76c3205 
* add MasterAuthorizedNetworksConfig filed into GCPManagedControlPlane CRD

* fix

* disable it if no desired specified in CR

* change to do not reconcile if the desired CR is nil

* add comment

add nil handling fo GcpPublicCidrsAccessEnabled

change nil as enabled

fix display_name not to be optional

address comments

fix typo and remove empty line
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinsb justinsb Awaiting requested review from justinsb

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

Assignees

@roberthbailey roberthbailey

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Doesn't work with latest minikube
3 participants
@oxddr @k8s-ci-robot @roberthbailey