Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build error for ibmcloud provider #1

Closed
gyliu513 opened this issue Apr 9, 2019 · 3 comments
Closed

Build error for ibmcloud provider #1

gyliu513 opened this issue Apr 9, 2019 · 3 comments
Assignees
@morvencao

Comments

@gyliu513
Copy link
Contributor

gyliu513 commented Apr 9, 2019 •
edited
Loading 

root@gyliu-dev1:~/go/src/sigs.k8s.io/cluster-api-provider-ibmcloud# make
go generate ./pkg/... ./cmd/...
go fmt ./pkg/... ./cmd/...
go vet ./pkg/... ./cmd/...
# sigs.k8s.io/cluster-api-provider-ibmcloud/pkg/controller
pkg/controller/add_cluster_controller.go:33:37: cannot use m (type "sigs.k8s.io/cluster-api-provider-ibmcloud/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager) as type "sigs.k8s.io/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager in argument to "sigs.k8s.io/cluster-api/pkg/controller/cluster".AddWithActuator:
	"sigs.k8s.io/cluster-api-provider-ibmcloud/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager does not implement "sigs.k8s.io/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager (wrong type for Add method)
		have Add("sigs.k8s.io/cluster-api-provider-ibmcloud/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Runnable) error
		want Add("sigs.k8s.io/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Runnable) error
pkg/controller/add_machine_controller.go:29:37: cannot use m (type "sigs.k8s.io/cluster-api-provider-ibmcloud/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager) as type "sigs.k8s.io/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager in argument to "sigs.k8s.io/cluster-api/pkg/controller/machine".AddWithActuator:
	"sigs.k8s.io/cluster-api-provider-ibmcloud/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager does not implement "sigs.k8s.io/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager (wrong type for Add method)
		have Add("sigs.k8s.io/cluster-api-provider-ibmcloud/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Runnable) error
		want Add("sigs.k8s.io/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Runnable) error
# sigs.k8s.io/cluster-api-provider-ibmcloud/cmd/manager [sigs.k8s.io/cluster-api-provider-ibmcloud/cmd/manager.test]
cmd/manager/main.go:56:35: cannot use cfg (type *"sigs.k8s.io/cluster-api-provider-ibmcloud/vendor/k8s.io/client-go/rest".Config) as type *"sigs.k8s.io/cluster-api/vendor/k8s.io/client-go/rest".Config in argument to clientset.NewForConfig
cmd/manager/main.go:82:49: cannot use mgr.GetScheme() (type *"sigs.k8s.io/cluster-api-provider-ibmcloud/vendor/k8s.io/apimachinery/pkg/runtime".Scheme) as type *"sigs.k8s.io/cluster-api/vendor/k8s.io/apimachinery/pkg/runtime".Scheme in argument to "sigs.k8s.io/cluster-api/pkg/apis".AddToScheme
cmd/manager/main.go:86:29: cannot use mgr (type "sigs.k8s.io/cluster-api-provider-ibmcloud/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager) as type "sigs.k8s.io/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager in argument to "sigs.k8s.io/cluster-api/pkg/controller/machine".AddWithActuator:
	"sigs.k8s.io/cluster-api-provider-ibmcloud/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager does not implement "sigs.k8s.io/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager (wrong type for Add method)
		have Add("sigs.k8s.io/cluster-api-provider-ibmcloud/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Runnable) error
		want Add("sigs.k8s.io/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Runnable) error
cmd/manager/main.go:88:29: cannot use mgr (type "sigs.k8s.io/cluster-api-provider-ibmcloud/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager) as type "sigs.k8s.io/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager in argument to "sigs.k8s.io/cluster-api/pkg/controller/cluster".AddWithActuator:
	"sigs.k8s.io/cluster-api-provider-ibmcloud/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager does not implement "sigs.k8s.io/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Manager (wrong type for Add method)
		have Add("sigs.k8s.io/cluster-api-provider-ibmcloud/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Runnable) error
		want Add("sigs.k8s.io/cluster-api/vendor/sigs.k8s.io/controller-runtime/pkg/manager".Runnable) error
Makefile:40: recipe for target 'vet' failed
make: *** [vet] Error 2
@gyliu513
Copy link
Contributor Author

gyliu513 commented Apr 9, 2019

@morvencao Can you help check? I think this is a bug in the document of https://kubernetes-sigs.github.io/cluster-api/ , we can fix here first and post PR in cluster api document.

@morvencao
Copy link
Contributor

@gyliu513 Sorry for the late repose.

We need to run

dep ensure

before make

@gyliu513
Copy link
Contributor Author

@morvencao it works for me, can you create a PR? Thanks.

This was referenced Apr 11, 2019
Merged
Closed
emmayang pushed a commit to emmayang/cluster-api-provider-ibmcloud that referenced this issue Oct 13, 2021
@wentao-zh
Merge pull request kubernetes-sigs#1 from emmayang/ibmcloud
3cf0759 
fix: typo: ibmachine should be ibmmachines
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@morvencao morvencao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gyliu513 @morvencao