get vm by name instead of search in a list #151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/work-in-progress
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: xunpan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
approved
xunpan
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
gyliu513
reviewed
May 20, 2019
| if len(guests) > 1 { | ||
| // I noticed that IBM Cloud can use same name for 2 machines. | ||
| // It is bad for our case. Print a message to make it to be noticed. | ||
| klog.Errorf("Getting more than one virtual guest. The first is used.") |
There was a problem hiding this comment.
Print out the guest name here for better debug.
gyliu513
reviewed
May 21, 2019
| if len(guests) > 1 { | ||
| // I noticed that IBM Cloud can use same name for 2 machines. | ||
| // It is bad for our case. Print a message to make it to be noticed. | ||
| klog.Errorf("Getting more than one virtual guests by filter (hostname=%s, domain=%s): %v. The first is used.", |
There was a problem hiding this comment.
How about The first host %s is used?
There was a problem hiding this comment.
I use guest ID because names are the same when the issue happens.
|
addressed comments and rebase done |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
make code logic simple and clear.
Specify your PR reviewers:
/cc @gyliu513 @jichenjc
Special notes for your reviewer:
Still need to do below things in this PR before review