use contextual logging #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: fabriziopandini The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
cncf-cla: yes
fabriziopandini
commented
Dec 22, 2022
hack/tools/go.mod
Outdated
| @@ -4,132 +4,194 @@ go 1.17 | |||
|
|
|||
| require ( | |||
| github.com/Masterminds/semver v1.5.0 | |||
| github.com/golangci/golangci-lint v1.32.0 | |||
| github.com/golangci/golangci-lint v1.48.0 | |||
There was a problem hiding this comment.
bumped otherwise lint was failing on M!
fabriziopandini
commented
Dec 22, 2022
hack/tools/go.mod
Outdated
| github.com/google/go-containerregistry v0.1.4 | ||
| github.com/spf13/pflag v1.0.5 | ||
| k8s.io/code-generator v0.25.0 |
There was a problem hiding this comment.
Added to get make generate-manifests/make verify to run
elmiko
reviewed
Dec 23, 2022
k8s-ci-robot
added
the
needs-rebase
fabriziopandini
force-pushed
the
use-contextstual-logging
branch
from
87890f1
to
55ed517
Compare
k8s-ci-robot
added
size/L
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Use contextual logging as per Cluster API/Kubernetes logging guidelines
Which issue this PR fixes:
fixes #
Special notes for your reviewer:
Release notes: