generated from kubernetes/kubernetes-template-project
-
Notifications
You must be signed in to change notification settings - Fork 65
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #90 from christopherhein/chore/golangci-cleanup-ex…
…cludes 🌱 Upgrade Golang CI & Fix Lint
- Loading branch information
Showing
39 changed files
with
1,283 additions
and
674 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,33 +1,122 @@ | ||
| linters: | ||
| enable-all: true | ||
| disable: | ||
| - dupl | ||
| - funlen | ||
| - gochecknoglobals | ||
| - gochecknoinits | ||
| - lll | ||
| - godox | ||
| - wsl | ||
| - whitespace | ||
| - gocognit | ||
| - gomnd | ||
| - interfacer | ||
| - godot | ||
| - goerr113 | ||
| - nestif | ||
| # Run with --fast=false for more extensive checks | ||
| fast: true | ||
| disable-all: true | ||
| enable: | ||
| - asciicheck | ||
| - bodyclose | ||
| - deadcode | ||
| - depguard | ||
| - dogsled | ||
| - exportloopref | ||
| - errcheck | ||
| - goconst | ||
| - gocritic | ||
| - gocyclo | ||
| - godot | ||
| - gofmt | ||
| - goimports | ||
| - goprintffuncname | ||
| - gosec | ||
| - gosimple | ||
| - govet | ||
| - importas | ||
| - ineffassign | ||
| - misspell | ||
| - nakedret | ||
| - nolintlint | ||
| - prealloc | ||
| - revive | ||
| - rowserrcheck | ||
| - staticcheck | ||
| - structcheck | ||
| - stylecheck | ||
| - typecheck | ||
| - unconvert | ||
| - unparam | ||
| - varcheck | ||
| - whitespace | ||
|
|
||
| linters-settings: | ||
| staticcheck: | ||
| go: "1.16" | ||
| stylecheck: | ||
| go: "1.16" | ||
| importas: | ||
| no-unaliased: true | ||
| alias: | ||
| # Kubernetes | ||
| - pkg: k8s.io/api/core/v1 | ||
| alias: corev1 | ||
| - pkg: k8s.io/apiextensions-apiserver/pkg/apis/apiextensions/v1 | ||
| alias: apiextensionsv1 | ||
| - pkg: k8s.io/apimachinery/pkg/apis/meta/v1 | ||
| alias: metav1 | ||
| - pkg: k8s.io/apimachinery/pkg/api/errors | ||
| alias: apierrors | ||
| - pkg: k8s.io/apimachinery/pkg/util/errors | ||
| alias: kerrors | ||
| # Controller Runtime | ||
| - pkg: sigs.k8s.io/controller-runtime | ||
| alias: ctrl | ||
|
|
||
| issues: | ||
| max-same-issues: 0 | ||
| max-issues-per-linter: 0 | ||
| # We are disabling default golangci exclusions because we want to help reviewers to focus on reviewing the most relevant | ||
| # changes in PRs and avoid nitpicking. | ||
| exclude-use-default: false | ||
| # List of regexps of issue texts to exclude, empty list by default. | ||
| exclude: | ||
| - Using the variable on range scope `(tc)|(rt)|(tt)|(test)|(testcase)|(testCase)` in function literal | ||
| - "G108: Profiling endpoint is automatically exposed on /debug/pprof" | ||
| - "G108: Profiling endpoint is automatically exposed on /debug/pprof" | ||
| - Error return value of .((os\.)?std(out|err)\..*|.*Close|.*Flush|os\.Remove(All)?|.*print(f|ln)?|os\.(Un)?Setenv). is not checked | ||
| - "exported: exported method .*\\.(Reconcile|SetupWithManager|SetupWebhookWithManager) should have comment or be unexported" | ||
| # The following are being worked on to remove their exclusion. This list should be reduced or go away all together over time. | ||
| # If it is decided they will not be addressed they should be moved above this comment. | ||
| - Subprocess launch(ed with variable|ing should be audited) | ||
| - (Expect directory permissions to be 0750 or less|Expect file permissions to be 0600 or less) | ||
| - (G104|G307) | ||
| exclude-rules: | ||
| # With Go 1.16, the new embed directive can be used with an un-named import, | ||
| # revive (previously, golint) only allows these to be imported in a main.go, which wouldn't work for us. | ||
| # This directive allows the embed package to be imported with an underscore everywhere. | ||
| - linters: | ||
| - revive | ||
| source: _ "embed" | ||
| # Exclude some packages or code to require comments, for example test code, or fake clients. | ||
| - linters: | ||
| - revive | ||
| text: exported (method|function|type|const) (.+) should have comment or be unexported | ||
| source: (func|type).*Fake.* | ||
| - linters: | ||
| - revive | ||
| text: exported (method|function|type|const) (.+) should have comment or be unexported | ||
| path: fake_\.go | ||
| - linters: | ||
| - revive | ||
| text: exported (method|function|type|const) (.+) should have comment or be unexported | ||
| path: .*test/(providers|framework|e2e).*.go | ||
| # Disable unparam "always receives" which might not be really | ||
| # useful when building libraries. | ||
| - linters: | ||
| - unparam | ||
| text: always receives | ||
| # Dot imports for gomega or ginkgo are allowed | ||
| # within test files. | ||
| - path: _test\.go | ||
| text: should not use dot imports | ||
| - path: _test\.go | ||
| text: cyclomatic complexity | ||
| - path: test/(framework|e2e).*.go | ||
| text: should not use dot imports | ||
| # Append should be able to assign to a different var/slice. | ||
| - linters: | ||
| - gocritic | ||
| text: "appendAssign: append result not assigned to the same slice" | ||
|
|
||
| run: | ||
| timeout: 10m | ||
| skip-files: | ||
| - "zz_generated.*\\.go$" | ||
| - ".*conversion.*\\.go$" | ||
| - "zz_generated.*\\.go$" | ||
| - ".*conversion.*\\.go$" | ||
| skip-dirs: | ||
| - third_party | ||
| - third_party | ||
| allow-parallel-runners: true |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.