Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Setup Prow Presubmits #46

Closed
christopherhein opened this issue May 5, 2021 · 1 comment · Fixed by #49
Closed

🌱 Setup Prow Presubmits #46

christopherhein opened this issue May 5, 2021 · 1 comment · Fixed by #49
Assignees

Comments

@christopherhein
Copy link
Member

We should have our PRs being tested for us with Prow on PR submission so we can have better assurance of the code.

Links

Our pre-submit should run make generate lint test. This should be called from a script like other Cluster API providers so that we can periodically change what it does without needing to update the test-infra repo. EG https://github.com/kubernetes-sigs/cluster-api-provider-aws/tree/main/scripts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant