Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add scaffolding #24

Merged
merged 1 commit into from Dec 7, 2020
Merged

Conversation

charleszheng44
Copy link
Contributor

@charleszheng44 charleszheng44 commented Dec 4, 2020

This PR adds the scaffolding generated by kubebuilder v3.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 4, 2020
@charleszheng44 charleszheng44 changed the title add scaffolding code Add scaffolding Dec 4, 2020
@k8s-ci-robot k8s-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Dec 4, 2020
@christopherhein
Copy link
Member

/assign

@christopherhein
Copy link
Member

Fixes #19

@charleszheng44 charleszheng44 changed the title Add scaffolding WIP: Add scaffolding Dec 4, 2020
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 4, 2020
@charleszheng44 charleszheng44 changed the title WIP: Add scaffolding Add scaffolding Dec 7, 2020
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 7, 2020
@christopherhein
Copy link
Member

We're going to need to regenerate this unfortunately and maybe to make this a little easier we should start with this PR only adding in the one type first, maybe NCP as a blank resource then we can add the rest of the types in individual PRs.

Specifically cause these we're generated with the wrong proper boilerplate so the license headers are messed up - https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/master/hack/boilerplate.go.txt and also the wrong domain and groups. https://github.com/kubernetes-sigs/cluster-api-provider-nested/blob/master/PROJECT#L2 should have been cluster.x-k8s.io and the groups for NCP, NKAS, NCM, NEtcd should all be under the group controlplane https://github.com/kubernetes-sigs/cluster-api-provider-nested/pull/24/files#diff-d1fb402f1269ba7396dca9cbd03b44ac055874669bce1d0f239fa2f54ea3584bR6.

@christopherhein
Copy link
Member

We also should have these kinds under the v1alpha4 api instead of v1alpha1.

@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Dec 7, 2020
@christopherhein
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 7, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charleszheng44, christopherhein

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 7, 2020
@k8s-ci-robot k8s-ci-robot merged commit 6698808 into kubernetes-sigs:master Dec 7, 2020
@charleszheng44 charleszheng44 deleted the scaffolding branch August 30, 2021 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants