Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement the NestedControllerManager controller #40

Merged
merged 1 commit into from Apr 10, 2021
Merged

Implement the NestedControllerManager controller #40

merged 1 commit into from Apr 10, 2021

Conversation

charleszheng44
Copy link
Contributor

This PR includes the implementation for the NestedControllerManager

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Apr 6, 2021
Fei-Guo
Fei-Guo reviewed Apr 7, 2021
View reviewed changes
Copy link

@Fei-Guo Fei-Guo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikhita
Copy link
Member

nikhita commented Apr 7, 2021

creating a (dummy) approve comment to re-trigger CI, the approval mechanism was broken for a bit - kubernetes/test-infra#21687

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charleszheng44, nikhita

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2021
christopherhein
christopherhein reviewed Apr 8, 2021
View reviewed changes
controllers/controlplane/controller_util.go
return fmt.Errorf("fail to generate the "+
"NesteEtcd Service object: %v", err)
if ncKind != clusterv1.ControllerManager {
// no need to create the service for the NestedControllerManager
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a note: For now I think this is true but if we want to run things like metrics service and be able to expose these we'd want the capability later.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I agree. We can add it back once we need to access the controller manager

@christopherhein
Copy link
Member

Just the one nit about copyright, lgtm otherwise

@christopherhein
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 10, 2021
@k8s-ci-robot k8s-ci-robot merged commit cc0d391 into kubernetes-sigs:master Apr 10, 2021
@christopherhein christopherhein mentioned this pull request May 5, 2021
Closed
@charleszheng44 charleszheng44 mentioned this pull request Jun 3, 2021
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherhein christopherhein christopherhein left review comments

@Fei-Guo Fei-Guo Fei-Guo left review comments

Assignees

@christopherhein christopherhein

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@charleszheng44 @nikhita @k8s-ci-robot @christopherhein @Fei-Guo