NestedControlPlane & NestedCluster Controllers #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/work-in-progress
k8s-ci-robot
added
approved
christopherhein
force-pushed
the
feature/ncp-controller
branch
from
dfe5aff
to
9d21451
Compare
christopherhein
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/assign @charleszheng44 @Fei-Guo |
|
LGTM. I will leave to @charleszheng44 to give another pass. |
charleszheng44
suggested changes
May 6, 2021
| @@ -71,29 +78,64 @@ spec: | |||
| periodSeconds: 2 | |||
| timeoutSeconds: 30 | |||
| volumeMounts: | |||
| - mountPath: /etc/kubernetes/pki/proxy/ca | |||
There was a problem hiding this comment.
does the apiserver need the proxy ca?
There was a problem hiding this comment.
Not with how it's configured in here right now. I can remove this.
There was a problem hiding this comment.
Updated and removed these unused mounts.
Signed-off-by: Chris Hein <me@chrishein.com>
Signed-off-by: Chris Hein <me@chrishein.com>
christopherhein
force-pushed
the
feature/ncp-controller
branch
from
9d21451
to
5257ffb
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: charleszheng44, christopherhein The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds in the NCP and NC controllers for orchestrating the control plane creation by setting up all PKI and creating necessary components.
TODO:
clusterctlworks forkubeconfigsRelated
closes #33
closes #32