New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

`FailedCreateServer` error event was removed while it's still being tested #2111

Closed

EmilienM opened this issue Jun 4, 2024 · 0 comments · Fixed by #2112

Contributor

EmilienM commented Jun 4, 2024 •

edited

Loading

In this PR, FailedCreateServer error event was removed while it's still being tested:

cluster-api-provider-openstack/test/e2e/suites/e2e/e2e_test.go

Line 616 in a63ce56

    
           return isErrorEventExists(namespace.Name, mdInvalidAZName, "FailedCreateServer", azError, eventList)

I have no idea how our CI didn't catch that 🤷 but for sure I'll take a look.

Originally posted by @EmilienM in #1753 (comment)

The text was updated successfully, but these errors were encountered:

EmilienM changed the title FailedCreateServer error event was removed while it's still being tested: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/blob/a63ce561e12131f7853f04a731b3a5ddb1cefa86/test/e2e/suites/e2e/e2e_test.go#L616 FailedCreateServer error event was removed while it's still being tested

EmilienM mentioned this issue

🐛 instance: re-add error event if server creationg returned an error #2112

Merged

k8s-ci-robot closed this as completed in #2112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment