Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

separate machine_providerconfig and cluster_provider config #34

Closed
Lion-Wei opened this issue Oct 8, 2018 · 5 comments
Closed

separate machine_providerconfig and cluster_provider config #34

Lion-Wei opened this issue Oct 8, 2018 · 5 comments
Assignees

Comments

@Lion-Wei
Copy link

Lion-Wei commented Oct 8, 2018

OpenstackProviderConfig can be separated into cluster scope and machine scope.

@scruplelesswizard
Copy link
Contributor

Based on the skeleton repo maybe we should split the machine and cluster actuators into separate packages as well?

@Lion-Wei
Copy link
Author

Lion-Wei commented Oct 8, 2018

For now we don't have cluster actuators, but sure, when we add cluster actuators, we need consider separate then in two packages.

@chrigl
Copy link

chrigl commented Nov 26, 2018

/assign @chrigl
Actuators already separated by #94.

I am currently working on an implementation of the cluster actuator which needs its own ProviderSpec. See #106.

@scruplelesswizard
Copy link
Contributor

/close

@k8s-ci-robot
Copy link
Contributor

@chaosaffe: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

iamemilio pushed a commit to iamemilio/cluster-api-provider-openstack that referenced this issue Apr 17, 2019
machine/actuator: Fix Update instance status
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants