Basic cluster reconciler #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
k8s-ci-robot
added
the
do-not-merge/work-in-progress
|
Needs a rebase and minor change when #136 is in. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chaosaffe, chrigl The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
added 2 commits
December 21, 2018 15:07
Added ports for subnets to router Implemented cluster update Replaced glog by klog Changed usage of NetworService Now Reconcile creates an instance of NetworkService on each run. So in theory it will be possible to configure OS-Credentials per cluster. Added router to ClusterStatus Changed to only one Router Resynced Gopkg.lock Improved logs Reconciling of networks now log the default log level Added Docs to ClusterStatus.Network Recreated zz_generated with new types
chrigl
force-pushed
the
basic-cluster-reconciler
branch
from
58aa174
to
eccdacc
Compare
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
Huge rebase necessary because of 136. But everything works now. |
ainmosni
reviewed
Jan 3, 2019
added 3 commits
January 3, 2019 15:33
At the current point in time, we don't need multiple subnets, and we are not even able to configure them. Beside this, I refactored the reconciling code to return network, subnet and router instead of manipulating pointer data.
See also kubernetes-retired/kubefed#208 (comment) We don't need the clientset_generated any more.
|
/lgtm |
k8s-ci-robot
added
the
lgtm
flaper87
pushed a commit
to flaper87/cluster-api-provider-openstack
that referenced
this pull request
Jan 9, 2019
* Basic implementation of creating networks Added ports for subnets to router Implemented cluster update Replaced glog by klog Changed usage of NetworService Now Reconcile creates an instance of NetworkService on each run. So in theory it will be possible to configure OS-Credentials per cluster. Added router to ClusterStatus Changed to only one Router Resynced Gopkg.lock Improved logs Reconciling of networks now log the default log level Added Docs to ClusterStatus.Network Recreated zz_generated with new types * Migrated to params of PR 136 * removed unneeded line * Updated Network to only hold a single subnet At the current point in time, we don't need multiple subnets, and we are not even able to configure them. Beside this, I refactored the reconciling code to return network, subnet and router instead of manipulating pointer data. * Removed unneeded clusterclient in favor of runtime.Client See also kubernetes-retired/kubefed#208 (comment) We don't need the clientset_generated any more. * Fixed typos, re-ordered fields
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Implemented basic cluster reconciler. When a
Cluster.NodeCIDRand aCluster.ExternalNetworkIDare configured, the cluster reconciler creates an OpenStack Network with an associated Subnet (this will hold the IP range). Additionally an OpenStack router will be create, and attached to the just created Subnet as well as theExternalNetworkIDto get public internet to the VMs. All of the created components are stored inOpenstackClusterProviderStatus.With this, we are able to change the machine actuator to use the Network from
Cluster.Status.ProviderSpec.Network. It could be still possible to configure networks on Machine bases.This code does not interfere with current cluster creation. If there is no network configuration on the cluster, the cluster actuator only is a noop as before.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #106
Special notes for your reviewer:
In order to test use this image:
chrigl/openstack-cluster-api-controller:latestRelease note: