🌱 ci: bump flatcar to latest major stable #1524

tormath1 · 2023-04-17T17:57:54Z

What this PR does / why we need it: This PR brings the new Flatcar stable version in the CI - for now it runs from a non-official bucket, just for running the tests.

Special notes for your reviewer: Hello @tobiasgiese, any chance to upload the image on the dedicated bucket please?

TODOs:

squashed commits
use the image from the capo bucket
if necessary:
- includes documentation
- adds unit tests

/hold

k8s-ci-robot · 2023-04-17T17:57:57Z

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

netlify · 2023-04-17T17:58:05Z

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	`1cbe68d`
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/643e90657c0c3f0008a6538b
😎 Deploy Preview	https://deploy-preview-1524--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

jichenjc · 2023-04-18T02:04:00Z

/test pull-cluster-api-provider-openstack-e2e-test

mdbooth · 2023-04-18T10:08:56Z

Looks like kubelet didn't come up on the control plane node? https://storage.googleapis.com/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-openstack/1524/pull-cluster-api-provider-openstack-e2e-test/1648225742087000064/artifacts/clusters/bootstrap/resources/e2e-njpkyi/Machine/cluster-e2e-njpkyi-control-plane-cp49m.yaml

  conditions:
  - lastTransitionTime: "2023-04-18T08:12:46Z"
    status: "True"
    type: Ready
  - lastTransitionTime: "2023-04-18T08:12:02Z"
    status: "True"
    type: BootstrapReady
  - lastTransitionTime: "2023-04-18T08:12:46Z"
    status: "True"
    type: InfrastructureReady
  - lastTransitionTime: "2023-04-18T08:12:02Z"
    reason: WaitingForNodeRef
    severity: Info
    status: "False"
    type: NodeHealthy

We're missing logs from this server: https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-openstack/1524/pull-cluster-api-provider-openstack-e2e-test/1648225742087000064/artifacts/clusters/bootstrap/instances/e2e-njpkyi/cluster-e2e-njpkyi-control-plane-nj7m9/

Compare and contrast with:

https://gcsweb.k8s.io/gcs/kubernetes-jenkins/pr-logs/pull/kubernetes-sigs_cluster-api-provider-openstack/1524/pull-cluster-api-provider-openstack-e2e-test/1648225742087000064/artifacts/clusters/bootstrap/instances/e2e-atfc1t/cluster-e2e-atfc1t-control-plane-6bkcp/

Are those logs normally there for flatcar runs? i.e. Do we need to fix the missing logs to determine the problem, or are the missing logs a symptom of the problem?

tormath1 · 2023-04-18T10:19:02Z

@mdbooth I'll try to repro this afternoon - but seeing this:

  couldn't dial from local to machine 10.6.0.37: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
  couldn't dial from local to machine 10.6.0.37: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
  couldn't dial from local to machine 10.6.0.37: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
  couldn't dial from local to machine 10.6.0.37: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
  couldn't dial from local to machine 10.6.0.37: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
  couldn't dial from local to machine 10.6.0.37: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
  couldn't dial from local to machine 10.6.0.37: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain

makes me think that the bastion is not even able to SSH into the instance; might be an issue with provisioning ?

tormath1 · 2023-04-18T10:23:46Z

@mdbooth ah... I think I know. This provisioning thing can only be an Ignition issue and looking at my command history, it seems I locally built the image without OEM_ID=openstack (as suggested in the documentation I wrote myself: https://cluster-api-openstack.sigs.k8s.io/clusteropenstack/configuration.html#operating-system-image) - so Flatcar tries to fetch Ignition in the qemu way and not in the OpenStack way.
One more reason to automate the build :D

tormath1 · 2023-04-18T11:00:01Z

/test pull-cluster-api-provider-openstack-e2e-test

mdbooth · 2023-04-18T12:33:38Z

hack/ci/cloud-init/controller.yaml.tpl

@@ -138,7 +138,7 @@
    # https://docs.openstack.org/glance/latest/admin/quotas.html
    /opt/stack/devstack/tools/upload_image.sh https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/cirros/2022-12-05/cirros-0.6.1-x86_64-disk.img
    /opt/stack/devstack/tools/upload_image.sh https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/ubuntu/2023-01-14/focal-server-cloudimg-amd64.img
-    /opt/stack/devstack/tools/upload_image.sh https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/flatcar/flatcar-stable-3374.2.5-kube-v1.25.6.img
+    /opt/stack/devstack/tools/upload_image.sh https://storage.googleapis.com/tormath1-flatcar/flatcar-stable-3510.2.0-kube-v1.25.8.img


Tests pass. Shall I upload this to the staging bucket?

If you have the access yes please!

Actually I just went ahead and did it. It's available at https://storage.googleapis.com/artifacts.k8s-staging-capi-openstack.appspot.com/test/flatcar/flatcar-stable-3510.2.0-kube-v1.25.8.img

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>

mdbooth · 2023-04-18T12:43:51Z

/approve

k8s-ci-robot · 2023-04-18T12:43:58Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, tormath1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

tormath1 · 2023-04-18T14:26:07Z

/unhold

mdbooth · 2023-04-18T14:54:58Z

/lgtm

tormath1 marked this pull request as ready for review April 17, 2023 17:58

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 17, 2023

k8s-ci-robot requested review from lentzi90 and mdbooth April 17, 2023 17:58

k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 17, 2023

k8s-ci-robot requested a review from seanschneeweiss April 17, 2023 17:58

tormath1 mentioned this pull request Apr 17, 2023

Release Flatcar Container Linux Alpha 3572.0.0, Beta 3549.1.0, Stable 3510.2.0, LTS 3033.3.11 flatcar/Flatcar#996

Closed

34 tasks

tormath1 force-pushed the tormath1/flatcar-stable branch from c3de32a to bfd07a6 Compare April 18, 2023 07:23

mdbooth reviewed Apr 18, 2023

View reviewed changes

ci: bump flatcar to latest major stable

1cbe68d

Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>

tormath1 force-pushed the tormath1/flatcar-stable branch from bfd07a6 to 1cbe68d Compare April 18, 2023 12:43

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 18, 2023

k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 18, 2023

k8s-ci-robot assigned mdbooth Apr 18, 2023

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 18, 2023

k8s-ci-robot merged commit 4f29063 into kubernetes-sigs:main Apr 18, 2023

tormath1 deleted the tormath1/flatcar-stable branch April 18, 2023 15:18

tormath1 mentioned this pull request Oct 9, 2023

🌱 ci: bump Flatcar tested version #1713

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

🌱 ci: bump flatcar to latest major stable #1524

🌱 ci: bump flatcar to latest major stable #1524

tormath1 commented Apr 17, 2023 •

edited

Loading

k8s-ci-robot commented Apr 17, 2023

netlify bot commented Apr 17, 2023 •

edited

Loading

jichenjc commented Apr 18, 2023

mdbooth commented Apr 18, 2023

tormath1 commented Apr 18, 2023

tormath1 commented Apr 18, 2023

tormath1 commented Apr 18, 2023

mdbooth Apr 18, 2023

tormath1 Apr 18, 2023

mdbooth Apr 18, 2023

mdbooth commented Apr 18, 2023

k8s-ci-robot commented Apr 18, 2023

tormath1 commented Apr 18, 2023

mdbooth commented Apr 18, 2023

🌱 ci: bump flatcar to latest major stable #1524

🌱 ci: bump flatcar to latest major stable #1524

Conversation

tormath1 commented Apr 17, 2023 • edited Loading

k8s-ci-robot commented Apr 17, 2023

netlify bot commented Apr 17, 2023 • edited Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

jichenjc commented Apr 18, 2023

mdbooth commented Apr 18, 2023

tormath1 commented Apr 18, 2023

tormath1 commented Apr 18, 2023

tormath1 commented Apr 18, 2023

mdbooth Apr 18, 2023

Choose a reason for hiding this comment

tormath1 Apr 18, 2023

Choose a reason for hiding this comment

mdbooth Apr 18, 2023

Choose a reason for hiding this comment

mdbooth commented Apr 18, 2023

k8s-ci-robot commented Apr 18, 2023

tormath1 commented Apr 18, 2023

mdbooth commented Apr 18, 2023

tormath1 commented Apr 17, 2023 •

edited

Loading

netlify bot commented Apr 17, 2023 •

edited

Loading