Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Backport Provider to release-0.7 #1529

Merged
merged 1 commit into from
Apr 27, 2023
Merged

✨ Backport Provider to release-0.7 #1529

merged 1 commit into from
Apr 27, 2023

Conversation

Jeremy-Boyle
Copy link
Contributor

@Jeremy-Boyle Jeremy-Boyle commented Apr 25, 2023 •
edited
Loading

What this PR does / why we need it:
This back ports the Provider feature into v1alpha6, numerous users would like the feature however main is not in a state to push a release.

Back port is based on PR: #1501

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • Push back port to Main as provider has been moved to v1alpha6 PR: 🐛 Patch: Backport Provider to v1alpha6 #1530
  • Create Issue / Feature to track this work between the two merges.
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 25, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Apr 25, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: Jeremy-Boyle / name: Jeremy (19b3975)

@netlify
Copy link

netlify bot commented Apr 25, 2023 •
edited
Loading

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 19b3975
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6447e233e40fa600072819af
😎 Deploy Preview https://deploy-preview-1529--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. label Apr 25, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @Jeremy-Boyle!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 25, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @Jeremy-Boyle. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Apr 25, 2023
This was referenced Apr 25, 2023
Merged
Closed
@jichenjc
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 26, 2023
@jichenjc
Copy link
Contributor

usually we don't want to backport features to older release, mostly we backport bugs.. @mdbooth @seanschneeweiss any thoughts?

@ching-kuo
Copy link
Contributor

@jichenjc There's a discussion on slack about backporting this feature to release 0.7
https://kubernetes.slack.com/archives/CFKJB65G9/p1682078907625039

@jichenjc
Copy link
Contributor

Thanks for sharing , didn't notice that :(

@mdbooth
Copy link
Contributor

mdbooth commented Apr 26, 2023

usually we don't want to backport features to older release, mostly we backport bugs.. @mdbooth @seanschneeweiss any thoughts?

I'd normally agree, but:

  • we've got a few people waiting for this feature
  • it's a relatively simple backport
  • 0.8 might be a way out still

So we thought this was a pragmatic way forward.

@mdbooth
Copy link
Contributor

mdbooth commented Apr 26, 2023

/lgtm

I'll approve this after #1530 lands in main.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 26, 2023
dulek
dulek approved these changes Apr 26, 2023
View reviewed changes
Copy link
Contributor

@dulek dulek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I pointed out something I noticed inline, but this is part of the original patch, so obviously no need to fix it here.

pkg/cloud/services/loadbalancer/loadbalancer.go
Comment on lines +367 to +368
record.Warnf(openStackCluster, "SkippedCreateMonitor", "Health monitors are not supported with the current Octavia provider.")
record.Eventf(openStackCluster, "SkippedCreateMonitor", "Health Monitor is not created as it's not implemented with the current Octavia provider.")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only now I realized both Warnf() and Eventf() produce an event. We shouldn't need both, just Warnf() should be enough. Obviously that isn't something to fix here, but rather on master branch.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this is a carbon copy from what was inside of main from the existing v1alpha7 was trying to keep it as close as possible

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, it should be kept exactly like this. We can fix this on master and then backport the fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dulek Do you want to submit that while it's fresh in your mind?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#1531

@Jeremy-Boyle
Copy link
Contributor Author

#1530

is now in main

@Jeremy-Boyle
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2023
@mdbooth
Copy link
Contributor

mdbooth commented Apr 27, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dulek, Jeremy-Boyle, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 27, 2023
@k8s-ci-robot k8s-ci-robot merged commit c9239d5 into kubernetes-sigs:release-0.7 Apr 27, 2023
4 checks passed
@ching-kuo ching-kuo mentioned this pull request Aug 12, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dulek dulek dulek approved these changes

@mdbooth mdbooth mdbooth left review comments

@jichenjc jichenjc Awaiting requested review from jichenjc

@tobiasgiese tobiasgiese Awaiting requested review from tobiasgiese

Assignees

@mdbooth mdbooth

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Jeremy-Boyle @k8s-ci-robot @jichenjc @ching-kuo @mdbooth @dulek