remove subnet from the output in kubectl get

[jichenjc]

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1608

Special notes for your reviewer:

we made it subnets now , seems we can't get it if it's CRD
kubernetes-sigs/controller-tools#652

so remove seems better than show nothing ..

type NetworkStatusWithSubnets struct {
        NetworkStatus `json:",inline"`

        // Subnets is a list of subnets associated with the default cluster network. Machines which use the default cluster network will get an address from all of these subnets.
        Subnets []Subnet `json:"subnets,omitempty"`
}

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

/hold

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	8f3dbff
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/64b0c32e3bb09e00084222a8
😎 Deploy Preview	https://deploy-preview-1609--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[jichenjc]

@mdbooth pleaes take a quick look :)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jichenjc, mnaser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jichenjc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[jichenjc]

/test pull-cluster-api-provider-openstack-e2e-test

[jichenjc]

/test pull-cluster-api-provider-openstack-e2e-test

[mdbooth]

I knew it would be something like that! Thanks.

Are users going to miss this information? Is there any way to specify all subnet ids from the new slice in the JSONPath?

[jichenjc]

subnet => subnets means this is array.., as in the commit msg, I searched kubernetes-sigs/controller-tools#652 but seems they don't want to support it or maybe I missed something ?

[mdbooth]

It looks like yes: https://kubernetes.io/docs/reference/kubectl/jsonpath/

I can try to construct the correct incantation when I get back if you like (I'm on my phone right now).

Or... we could report network id instead.

Or just remove it like this. I don't understand how this information is used in practise, so it's hard for me to judge. That's the only reason I feel like the safest thing might be to retain it as a list of subnet ids.

What do you think?

[jichenjc]

no rush :)

I think we already provide net id ?
#1608 (comment)

I believe if they need subnet ID they can always describe ? if we can figure out better later we can add it back
for now, remove the heading is better than emty value to confuse people ?

[mdbooth]

/lgtm

Lets get rid of it because, as you say: it's definitely wrong right now. We can add subnets later if anybody asks for it, but as we're removing subnet anyway I think this is reasonable.

[jichenjc]

/hold cancel