Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add support to IPv6 in Machine's status #1633

Merged
merged 1 commit into from Aug 11, 2023
Merged

✨ Add support to IPv6 in Machine's status #1633

merged 1 commit into from Aug 11, 2023

Conversation

MaysaMacedo
Copy link
Contributor

@MaysaMacedo MaysaMacedo commented Aug 4, 2023 •
edited

Dual-stack clusters require that the Machine's status contains the
IPv6 address. This commit removed the check that would skip the addition
of IPv6 to the Machines. Also, it ensures the IPv4 addresses of each
Network remains being the first ones listed in the Machines given there are
operations that rely on the first address of each network.

@netlify
Copy link

netlify bot commented Aug 4, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 5926f47
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/64d159e055a40c000858d22d
😎 Deploy Preview https://deploy-preview-1633--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @MaysaMacedo!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 4, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @MaysaMacedo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 4, 2023
@MaysaMacedo
Copy link
Contributor Author

Here is how Machine's address field looks like once this change is included:

status:
  addresses:
  - address: fd2e:6f44:5dd8:c956::165
    type: InternalIP
  - address: 192.168.25.158
    type: InternalIP
  - address: ostest-twv6v-master-2
    type: Hostname
  - address: ostest-twv6v-master-2
    type: InternalDNS

@MaysaMacedo
Copy link
Contributor Author

/cc @mdbooth

@mnaser
Copy link
Contributor

mnaser commented Aug 4, 2023

@MaysaMacedo maybe this is really an edge case, but would it make sense for us to try and find a way to order IPv4 addreses first then IPv6 next?

I'm just wondering in the edge case scenario that someone is relying on the first item of the addresses section as the IP address and they're surprised to see it become IPv6.

It's totally a small thing though, I think it's probably fine as is, but thought i'd call it out.

@mnaser
Copy link
Contributor

mnaser commented Aug 4, 2023

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 4, 2023
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 7, 2023
@MaysaMacedo MaysaMacedo force-pushed the remove-restriction-ipv6 branch 2 times, most recently from 86bb01b to e40ef02 Compare August 7, 2023 19:29
@MaysaMacedo
Add support to IPv6 in Machine's status
5926f47 
Dual-stack clusters require that the Machine's status contains the
IPv6 address. This commit removed the check that would skip the addition
of IPv6 to the Machines. Also, it ensures the IPv4 addresses of each
Network remains being the first ones listed in the Machines given there are
operations that rely on the first address of each network.
@MaysaMacedo
Copy link
Contributor Author

Here is how Machine's status looks like with the latest changes:

status:
  addresses:
  - address: 192.168.25.50
    type: InternalIP
  - address: fd2e:6f44:5dd8:c956::23
    type: InternalIP
  - address: 10.196.3.139
    type: InternalIP
  - address: ostest-gqvh8-worker-0-j9trj
    type: Hostname
  - address: ostest-gqvh8-worker-0-j9trj
    type: InternalDNS

@dulek
Copy link
Contributor

dulek commented Aug 8, 2023

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Aug 8, 2023
@MaysaMacedo
Copy link
Contributor Author

/assign @justinsb

mdbooth
mdbooth reviewed Aug 11, 2023
View reviewed changes
Copy link
Contributor

@mdbooth mdbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Looks good, thanks!

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MaysaMacedo, mdbooth, mnaser

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 11, 2023
@k8s-ci-robot k8s-ci-robot merged commit 77411ad into kubernetes-sigs:main Aug 11, 2023
10 checks passed
@mdbooth mdbooth deleted the remove-restriction-ipv6 branch August 11, 2023 13:39
@MaysaMacedo MaysaMacedo mentioned this pull request Dec 26, 2023
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbooth mdbooth mdbooth left review comments

@mnaser mnaser mnaser approved these changes

@dulek dulek Awaiting requested review from dulek

@seanschneeweiss seanschneeweiss Awaiting requested review from seanschneeweiss

Assignees

@justinsb justinsb

@dulek dulek

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MaysaMacedo @k8s-ci-robot @mnaser @dulek @mdbooth @justinsb