🐛 Fix application credential support in env.rc #1646
Conversation
k8s-ci-robot
added
do-not-merge/hold
|
Hi @wwentland. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
the
needs-ok-to-test
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/S
This allows users to utilise authentication via application credentials again rather than expecting them to use passwords. Specifically, users that use a cloud.conf with application credentials would run into an error such as: ``` $ source ./templates/env.rc ~/.config/openstack/clouds.yaml example Error: Value for env variable 'PASSWORD' not provided in env() ``` with the resulting `CAPO_OPENSTACK_CLOUD_YAML_SELECTED_CLOUD_B64` environment variable containing content similar to: ``` clouds: example: ``` This commit only includes the password if it does indeed have a value, to ensure that the cloud config file can be rendered correctly.
wwentland
force-pushed
the
fix-envrc-appcred
branch
from
7b0e047
to
07ee324
Compare
|
/ok-to-test |
k8s-ci-robot
added
ok-to-test
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, wwentland The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
What this PR does / why we need it:
This allows users to utilise authentication via application credentials again rather than expecting them to use passwords.
Specifically, users that use a cloud.conf with application credentials would run into an error such as:
with the resulting
CAPO_OPENSTACK_CLOUD_YAML_SELECTED_CLOUD_B64environment variable containing content similar to:This commit only includes the password if it does indeed have a value, to ensure that the cloud config file can be rendered correctly.
The erroneous behaviour was introduced in #1381
/hold