🌱 Bump golangci-lint to 1.54.2 #1652
Conversation
k8s-ci-robot
added
the
do-not-merge/hold
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
cncf-cla: yes
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
size/S
|
/hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
| @@ -258,7 +258,7 @@ func deleteBastion(scope scope.Scope, cluster *clusterv1.Cluster, openStackClust | |||
| return nil | |||
| } | |||
|
|
|||
| func reconcileNormal(scope scope.Scope, cluster *clusterv1.Cluster, openStackCluster *infrav1.OpenStackCluster) (ctrl.Result, error) { | |||
| func reconcileNormal(scope scope.Scope, cluster *clusterv1.Cluster, openStackCluster *infrav1.OpenStackCluster) (ctrl.Result, error) { //nolint:unparam | |||
There was a problem hiding this comment.
Can we make the unused param(s) _ instead to make it more obvious?
There was a problem hiding this comment.
um... from code all 3 params are used , not sure why need such update to make CI happy
There was a problem hiding this comment.
Ah now I see... the issue is that the returned ctrl.Result is always empty == nil.
There was a problem hiding this comment.
Yeah. I thought about this one a bit. We could remove the ctrl.Result return from this function, but:
- That would make it different to all other reconcile methods (and therefore Surprising)
- It might encourage lazy programming when we inevitably want to add it back
Co-authored-by: Lennart Jern <lennart.jern@gmail.com>
k8s-ci-robot
added
the
lgtm
Note that this disables depguard which we had previously explicitly enabled but we don't seem to have a config for. With this upgrade and with no config it complains about all imports. It looks potentially useful to avoid accidental problematic imports like Hashicorp, but we can look into that separately.
/hold