🌱 Import CAPI v1.6.0

[EmilienM]

What this PR does / why we need it:

• Vendoring:

  • Import CAPI v1.6.0
  • controller-runtime v0.16.3
  • kubernetes v1.28.3
  • other deps bumps

• Code updates:

  • Makefile: use the new CAPI
  • main: convert deprecated metrics binding server to diagnostics arguments, like requested by CAPI. I followed the exact same pattern as CAPZ who also followed what is recommended in CAPI
  • main: update RBAC for diagnostics
  • main: update cache and clients fields for new CAPI API
  • config manager: use the new diagnostics args
  • update e2e manifests for using new CAPI

Fixes #1734

TODOs:

• squashed commits - we don't squash since it involves vendoring.
• if necessary:
  • includes documentation - no doc update is needed.
  • adds unit tests - no test updates are needed.

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	6a792da
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/6571cc5212c1890008503d7a
😎 Deploy Preview	https://deploy-preview-1731--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[EmilienM]

/assign mdbooth

[EmilienM]

/hold
I'll come back to it once we have a new CAPI release.

[EmilienM]

/test pull-cluster-api-provider-openstack-e2e-test

[EmilienM]

I'm trying to bump Golang into a separate PR if possible, so we separate problems and fix them one by one: #1740

[EmilienM]

This is working, cool. We are now waiting for the final CAPI 1.6.0 release (end of November), then I'll update the vendoring but the other commit should be an easy update.

[lentzi90]

Looks great!
Waiting with LGTM until the release is finalized

[EmilienM]

/test pull-cluster-api-provider-openstack-e2e-test

[mdbooth]

@EmilienM FYI I bumped this to the release version.

I'm not 100% sure about the removal of --metrics-bind-addr. This feels like a significant breaking change. We should examine it carefully and if it's definitely necessary we need to document it.

I see controller-runtime now supports secure metrics with kubernetes-sigs/controller-runtime#2407. I'm guessing we probably need to continue to support insecure metrics, though. In fact, would we need to add support for secure metrics by passing in a cert to use?

[mdbooth]

Hah, we were never exposing port 8080 anyway!

[mdbooth]

Until we've sorted out how we want to expose secure metrics, please can we put this back to the old, insecure. Also I'd prefer not to add new cluster api variables for substitution in this change. Lets do that separately and deliberately when we understand this feature.

For now we could either:

• Leave it as it is. --metrics-bind-addr is deprecated but still works and has the same behaviour as before.
• Change it to --diagnostics-address=localhost:8080 --insecure-diagnostics=true, which keeps the same behaviour but without using the deprecated flag.

My feeling is that the prudent option is to entire revert the change to this file, leaving it exactly as it was before, and open an issue to track adding support for secure metrics.

[mdbooth]

Given that --metrics-bind-addr is still supported I think this doesn't have to be a breaking change. However, we're changing the default behaviour in the templates which is a breaking change. We should revert that part of the change.

I think if we revert the change to config/manager/manager.yaml this is no longer breaking change.

I pre-emptively opened an issue to track adding it properly: #1777

[mdbooth]

Lets re-run the tests with the command line arguments change reverted...

[mdbooth]

/approve
/lgtm

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mdbooth]

/hold cancel

[mdbooth]

/cherry-pick release-0.9

[k8s-infra-cherrypick-robot]

@mdbooth: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[k8s-infra-cherrypick-robot]

@mdbooth: new pull request created: #1780

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.