-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Make it possible to use a pre-created volume type in e2e tests #1766
🌱 Make it possible to use a pre-created volume type in e2e tests #1766
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Hi @maxrantil. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @lentzi90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
I think we could even do so that if the volume type does not exist we just error out directly, without trying to create it. For the CI, we can pre-create it here together with the flavors.
/ok-to-test
ef581dc
to
75ea552
Compare
de73665
to
3c9c3ca
Compare
984e52b
to
0359fc8
Compare
/test pull-cluster-api-provider-openstack-e2e-test |
1 similar comment
/test pull-cluster-api-provider-openstack-e2e-test |
b6e4d3c
to
17efa60
Compare
/cc @lentzi90 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good overall. I'm not understanding why we have the getVolumeType
though, and we should preferably not use admin credentials at all
Signed-off-by: Max Rantil <max.rantil@est.tech>
5eef099
to
a45a6a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job!
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, maxrantil The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
/hold cancel |
/test pull-cluster-api-provider-openstack-e2e-test |
Which issue(s) this PR fixes:
Fixes #1700
TODOs:
/hold