Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🐛 Fix potential panic during instance create #1803

Merged
merged 1 commit into from
Dec 22, 2023
Merged

🐛 Fix potential panic during instance create #1803

merged 1 commit into from
Dec 22, 2023

Conversation

mandre
Copy link
Contributor

@mandre mandre commented Dec 21, 2023

What this PR does / why we need it:

The FailedCreateServer event was mistakenly calling the Name() method on the createdInstance instance, that could very well be unitialized since creation failed. Instead, log the event using the named passed in the instance spec.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #1802

Special notes for your reviewer:

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

@mandre
Fix potential panic during instance create
f3f2959 
The `FailedCreateServer` event was mistakenly calling the `Name()`
method on the createdInstance instance, that could very well be
unitialized since creation failed. Instead, log the event using the
named passed in the instance spec.
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 21, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @mandre!

It looks like this is your first PR to kubernetes-sigs/cluster-api-provider-openstack 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/cluster-api-provider-openstack has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Dec 21, 2023
@k8s-ci-robot
Copy link
Contributor

Hi @mandre. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 21, 2023
@netlify Netlify
Copy link

netlify bot commented Dec 21, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit f3f2959
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/658440945b0121000829cbfc
😎 Deploy Preview https://deploy-preview-1803--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@mandre mandre mentioned this pull request Dec 21, 2023
Merged
@pierreprinetti
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Dec 21, 2023
@pierreprinetti
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 21, 2023
@dulek
Copy link
Contributor

dulek commented Dec 21, 2023

/lgtm

lentzi90
lentzi90 reviewed Dec 22, 2023
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, mandre

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 22, 2023
@k8s-ci-robot k8s-ci-robot merged commit e590271 into kubernetes-sigs:main Dec 22, 2023
9 checks passed
@pierreprinetti pierreprinetti deleted the create-instance-nil branch December 22, 2023 08:41
@mandre
Copy link
Contributor Author

mandre commented Jan 2, 2024

/cherry-pick release-0.9

@k8s-infra-cherrypick-robot
Copy link

@mandre: only kubernetes-sigs org members may request cherry picks. You can still do the cherry-pick manually.

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pierreprinetti
Copy link
Contributor

/cherry-pick release-0.9

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 2, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@pierreprinetti: new pull request created: #1806

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mandre mandre mentioned this pull request Jan 8, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lentzi90 lentzi90 lentzi90 left review comments

@dulek dulek Awaiting requested review from dulek

Assignees

@dulek dulek

@pierreprinetti pierreprinetti

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CreateInstance could panic when it fails to create the instance
6 participants
@mandre @k8s-ci-robot @pierreprinetti @dulek @k8s-infra-cherrypick-robot @lentzi90