Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Update CI to use OpenStack Bobcat #1804

Merged
merged 2 commits into from
Jan 15, 2024
Merged

✨ Update CI to use OpenStack Bobcat #1804

merged 2 commits into from
Jan 15, 2024

Conversation

EmilienM
Copy link
Contributor

@EmilienM EmilienM commented Dec 22, 2023 •
edited

What this PR does / why we need it:

Update devstack configuration to deploy OpenStack Bobcat with OVN on Ubuntu 22.04.

@netlify Netlify
Copy link

netlify bot commented Dec 22, 2023 •
edited

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit b75c40a
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65a20854c98a9d00085c727a
😎 Deploy Preview https://deploy-preview-1804--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 22, 2023
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 22, 2023
@EmilienM EmilienM changed the title Update CI to use OpenStack Zed ✨ Update CI to use OpenStack Zed Dec 22, 2023
@EmilienM EmilienM mentioned this pull request Dec 22, 2023
Closed
@EmilienM
Copy link
Contributor Author

I know Antelope is the latest stable version but I want to see how it works with Zed first (step by step).

@EmilienM
Copy link
Contributor Author

/test pull-cluster-api-provider-openstack-e2e-test

@EmilienM
Copy link
Contributor Author

EmilienM commented Jan 3, 2024

/test pull-cluster-api-provider-openstack-e2e-test

@EmilienM EmilienM changed the title ✨ Update CI to use OpenStack Zed ✨ Update CI to use OpenStack Bobcat Jan 3, 2024
@EmilienM
Copy link
Contributor Author

EmilienM commented Jan 3, 2024

/test pull-cluster-api-provider-openstack-e2e-test

MaysaMacedo
MaysaMacedo reviewed Jan 3, 2024
View reviewed changes
hack/ci/cloud-init/controller.yaml.tpl Outdated Show resolved Hide resolved
hack/ci/cloud-init/worker.yaml.tpl Outdated Show resolved Hide resolved
@MaysaMacedo
Copy link
Contributor

/test pull-cluster-api-provider-openstack-e2e-test

@mandre
Copy link
Contributor

mandre commented Jan 9, 2024

/retest

@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 9, 2024
@EmilienM EmilienM mentioned this pull request Jan 9, 2024
Open
7 tasks
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 11, 2024
@EmilienM
Copy link
Contributor Author

it's green! let's wait for #1796 to merge.

@EmilienM
Copy link
Contributor Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 13, 2024
@EmilienM
Copy link
Contributor Author

The tests work fine when we delete the bastion nodes, which make me think switching to bobcat highlight some resources issues in our jobs where some nodes goes into ERROR because "no valid host found" in Nova.
Maybe we need to reduce the number of concurrent clusters, or add MachineHealthChecks so Machines get re-created if an error, or mark heavy tests and avoid concurrency for these ones.

@EmilienM
Copy link
Contributor Author

when we reduce the control plane flavor, it seems to be fine.

@lentzi90 @jichenjc @mdbooth wdyt?

@jichenjc
Copy link
Contributor

when we reduce the control plane flavor, it seems to be fine.

I don't remember whether we have anything has impact on the performance, so seems your change (vcpu 4=>2) should be good

@lentzi90
Copy link
Contributor

2 vcpu should be fine for what we are doing, it is not like we stress the control plane with anything.
Let's check the full test also
/test pull-cluster-api-provider-openstack-e2e-full-test

lentzi90
lentzi90 reviewed Jan 15, 2024
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: EmilienM, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 15, 2024
@jichenjc
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5786940 into kubernetes-sigs:main Jan 15, 2024
9 of 10 checks passed
@jichenjc
Copy link
Contributor

@lentzi90 seems the CI not finished but it's merged, is the CI e2e test not a gate anymore (need pass in order to merge)

image

@mandre mandre deleted the zed branch January 15, 2024 08:40
@lentzi90
Copy link
Contributor

Oh! The e2e test is a gate but not the e2e-full. I should have realized to put hold. Well I guess we will soon know if it works or not 🙂

@EmilienM
Copy link
Contributor Author

Thanks for merging. Yes I'll keep an eye on that job, I run it nearly every day these days... :)

@lentzi90 lentzi90 mentioned this pull request Jan 16, 2024
Closed
@stephenfin stephenfin mentioned this pull request Jan 22, 2024
Closed
@EmilienM
Copy link
Contributor Author

EmilienM commented Feb 9, 2024

/cherry-pick release-0.9
/cherry-pick release-0.8

@k8s-infra-cherrypick-robot
Copy link

@EmilienM: #1804 failed to apply on top of branch "release-0.9":

Applying: Update CI to use OpenStack Bobcat & Ubuntu 22.04
.git/rebase-apply/patch:111: trailing whitespace.
    
warning: 1 line adds whitespace errors.
Using index info to reconstruct a base tree...
M	README.md
M	hack/ci/cloud-init/controller.yaml.tpl
M	hack/ci/gce-project.sh
Falling back to patching base and 3-way merge...
Auto-merging hack/ci/gce-project.sh
Auto-merging hack/ci/cloud-init/controller.yaml.tpl
Auto-merging README.md
CONFLICT (content): Merge conflict in README.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 Update CI to use OpenStack Bobcat & Ubuntu 22.04
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-0.9
/cherry-pick release-0.8

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@EmilienM EmilienM mentioned this pull request Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbooth mdbooth mdbooth left review comments

@MaysaMacedo MaysaMacedo MaysaMacedo left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@dulek dulek Awaiting requested review from dulek

Assignees

@jichenjc jichenjc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@EmilienM @MaysaMacedo @mandre @jichenjc @lentzi90 @k8s-ci-robot @k8s-infra-cherrypick-robot @mdbooth