Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ Add flags for configuring rate limits #1815

Merged
merged 1 commit into from
Jan 10, 2024
Merged

✨ Add flags for configuring rate limits #1815

merged 1 commit into from
Jan 10, 2024

Conversation

tobiasgiese
Copy link
Member

@tobiasgiese tobiasgiese commented Jan 10, 2024 •
edited

Our controller have built-in rate limits. It throttles itself if it hits this limit. So far it has not been possible to configure these limits. This commit adds flags to the controller for setting both the QPS and the burst for the rate limits. The default remains the same as before (20 QPS, 30 burst).

Copied from kubernetes-sigs/cluster-api#8579

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold
Tobias Giese tobias.giese@mercedes-benz.com, Mercedes-Benz Tech Innovation GmbH, legal info/Impressum

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 10, 2024
@netlify Netlify
Copy link

netlify bot commented Jan 10, 2024 •
edited

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit 591b2c4
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/659e5eb611bcff00088655f2
😎 Deploy Preview https://deploy-preview-1815--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jan 10, 2024
lentzi90
lentzi90 reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@lentzi90
Copy link
Contributor

Heh maybe better if someone else approves since I'm co-author 😅
/approve cancel
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2024
@lentzi90
Copy link
Contributor

/unapprove

@tobiasgiese
Copy link
Member Author

it is /remove-approve

@lentzi90
Copy link
Contributor

/remove-approve

@k8s-ci-robot k8s-ci-robot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@tobiasgiese @lentzi90
✨ Add flags for configuring rate limits
591b2c4 
Our controller have built-in rate limits. It throttles itself
if it hits this limit. So far it has not been possible to configure
these limits. This commit adds flags to the controller for setting both
the QPS and the burst for the rate limits. The default remains the same
as before (20 QPS, 30 burst).

Signed-off-by: Tobias Giese <tobias.giese@mercedes-benz.com>
Co-Authored-by: Lennart Jern <lennart.jern@est.tech>
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2024
lentzi90
lentzi90 reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@lentzi90 lentzi90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 10, 2024
@tobiasgiese
Copy link
Member Author

/hold cancel

feel free to merge

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 10, 2024
mdbooth
mdbooth reviewed Jan 10, 2024
View reviewed changes
Copy link
Contributor

@mdbooth mdbooth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

This is identical to CAPI 👌

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mdbooth, tobiasgiese

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 10, 2024
@mdbooth
Copy link
Contributor

mdbooth commented Jan 10, 2024

/cherry-pick release-0.9

@k8s-infra-cherrypick-robot
Copy link

@mdbooth: once the present PR merges, I will cherry-pick it on top of release-0.9 in a new PR and assign it to you.

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tobiasgiese
Copy link
Member Author

This is identical to CAPI 👌

See PR description 🙂 it's copied from @lentzi90 PR

@k8s-ci-robot k8s-ci-robot merged commit f47a3e5 into kubernetes-sigs:main Jan 10, 2024
9 checks passed
@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request Jan 10, 2024
Merged
@k8s-infra-cherrypick-robot
Copy link

@mdbooth: new pull request created: #1817

In response to this:

/cherry-pick release-0.9

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@tobiasgiese tobiasgiese deleted the tobiasgiese/rate-limits branch January 10, 2024 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdbooth mdbooth mdbooth left review comments

@lentzi90 lentzi90 lentzi90 left review comments

@dulek dulek Awaiting requested review from dulek

Assignees

@mdbooth mdbooth

@lentzi90 lentzi90

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tobiasgiese @lentzi90 @k8s-ci-robot @mdbooth @k8s-infra-cherrypick-robot