⚠️ Move FloatingIP to Bastion spec #1824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
approved
EmilienM
force-pushed
the
bastion-floating-ip
branch
from
674a8be
to
b6267e6
Compare
k8s-ci-robot
added
the
needs-rebase
EmilienM
force-pushed
the
bastion-floating-ip
branch
2 times, most recently
from
126e10a
to
b9ce15e
Compare
k8s-ci-robot
added
size/XXL
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
Re-adding commit which was previously erroneously added to v1alpha7 and reverted. (cherry picked from commit f19a6cc) Updated to target v1alpha8 instead of v1alpha7. Conversion code is reworked from previous commit to be minimal. Co-Authored-By: Matthew Booth <mbooth@redhat.com>
EmilienM
force-pushed
the
bastion-floating-ip
branch
from
b9ce15e
to
0796264
Compare
|
/test pull-cluster-api-provider-openstack-e2e-full-test |
k8s-ci-robot
added
size/L
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-cluster-api-provider-openstack-e2e-test |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jichenjc, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-adding commit which was previously erroneously added to v1alpha7 and reverted.
(cherry picked from commit f19a6cc)
Updated to target v1alpha8 instead of v1alpha7.
Conversion code is reworked from previous commit to be minimal.
Fixes: #1674