Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Decrease number of machines in e2e tests #1849

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

lentzi90
Copy link
Contributor

What this PR does / why we need it:

The e2e tests are currently very unstable. I suspect lack of resources in the devstack to be the issue. In an attempt to solve this, the number of control-plane nodes are reduced in this commit. Now only the multi-az test will use 3 CP. The rest will have 1 CP only.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

  • squashed commits
  • if necessary:
    • includes documentation
    • adds unit tests

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jan 31, 2024
Copy link

netlify bot commented Jan 31, 2024

Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name Link
🔨 Latest commit b0480b1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65ba576e8c792900083d11e1
😎 Deploy Preview https://deploy-preview-1849--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jan 31, 2024
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 31, 2024
The e2e tests are currently very unstable. I suspect lack of resources
in the devstack to be the issue. In an attempt to solve this, the number
of control-plane nodes are reduced in this commit. Now only the multi-az
test will use 3 CP. The rest will have 1 CP only.

Signed-off-by: Lennart Jern <lennart.jern@est.tech>
@lentzi90
Copy link
Contributor Author

Counting 1 success
/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

Successes: 2
Failures: 0
/test pull-cluster-api-provider-openstack-e2e-test

@EmilienM
Copy link
Contributor

Successes: 3
Failures: 0
/test pull-cluster-api-provider-openstack-e2e-test

@EmilienM
Copy link
Contributor

Successes: 4
Failures: 0
/test pull-cluster-api-provider-openstack-e2e-test

@EmilienM
Copy link
Contributor

Successes: 5
Failures: 0
/test pull-cluster-api-provider-openstack-e2e-test

@EmilienM
Copy link
Contributor

let's go up to 10 and call it a PR merged.

@EmilienM
Copy link
Contributor

#4 ERROR: failed to copy: httpReadSeeker: failed open: unexpected status code https://gcr.io/v2/distroless/static/manifests/sha256:112a87f19e83c83711cc81ce8ed0b4d79acd65789682a6a272df57c4a0858534: 502 Bad Gateway

Infra error, nothing related to e2e
/test pull-cluster-api-provider-openstack-e2e-test

@EmilienM
Copy link
Contributor

EmilienM commented Feb 1, 2024

Successes: 6
Failures: 0
/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

lentzi90 commented Feb 1, 2024

Successes: 7
Failures: 0
/test pull-cluster-api-provider-openstack-e2e-test

@jichenjc
Copy link
Contributor

jichenjc commented Feb 1, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

not sure worth this as well?

@lentzi90
Copy link
Contributor Author

lentzi90 commented Feb 1, 2024

/test pull-cluster-api-provider-openstack-e2e-full-test

not sure worth this as well?

Not doing any changes to those tests so it should not affect anything, but why not 🙂

@lentzi90
Copy link
Contributor Author

lentzi90 commented Feb 1, 2024

Successes: 8
Failures: 0
/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

lentzi90 commented Feb 1, 2024

Successes: 9
Failures: 0
/test pull-cluster-api-provider-openstack-e2e-test

@lentzi90
Copy link
Contributor Author

lentzi90 commented Feb 1, 2024

Alright that brings us to 10 successful jobs! (PR job history for reference: https://prow.k8s.io/pr-history/?org=kubernetes-sigs&repo=cluster-api-provider-openstack&pr=1849)
I say we should merge this! WDYT @mdbooth @tormath1 ?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lentzi90, tormath1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jichenjc
Copy link
Contributor

jichenjc commented Feb 1, 2024

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 1, 2024
@k8s-ci-robot k8s-ci-robot merged commit 5cc483b into kubernetes-sigs:main Feb 1, 2024
10 checks passed
@lentzi90 lentzi90 deleted the lentzi90/e2e-scale-down branch February 1, 2024 10:45
@EmilienM
Copy link
Contributor

EmilienM commented Feb 1, 2024

Thanks @lentzi90 for your time spent on this problem. I'm sure this will pay off in our CI stability!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants