-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🌱 Decrease number of machines in e2e tests #1849
🌱 Decrease number of machines in e2e tests #1849
Conversation
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
The e2e tests are currently very unstable. I suspect lack of resources in the devstack to be the issue. In an attempt to solve this, the number of control-plane nodes are reduced in this commit. Now only the multi-az test will use 3 CP. The rest will have 1 CP only. Signed-off-by: Lennart Jern <lennart.jern@est.tech>
6c29570
to
b0480b1
Compare
Counting 1 success |
Successes: 2 |
Successes: 3 |
Successes: 4 |
Successes: 5 |
let's go up to 10 and call it a PR merged. |
Infra error, nothing related to e2e |
Successes: 6 |
Successes: 7 |
/test pull-cluster-api-provider-openstack-e2e-full-test not sure worth this as well? |
Not doing any changes to those tests so it should not affect anything, but why not 🙂 |
Successes: 8 |
Successes: 9 |
Alright that brings us to 10 successful jobs! (PR job history for reference: https://prow.k8s.io/pr-history/?org=kubernetes-sigs&repo=cluster-api-provider-openstack&pr=1849) |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, tormath1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
Thanks @lentzi90 for your time spent on this problem. I'm sure this will pay off in our CI stability! |
What this PR does / why we need it:
The e2e tests are currently very unstable. I suspect lack of resources in the devstack to be the issue. In an attempt to solve this, the number of control-plane nodes are reduced in this commit. Now only the multi-az test will use 3 CP. The rest will have 1 CP only.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold