🐛Make sure that allowedCidrs lists are compared correctly to avoid patching LB listener when not needed

[huxcrux]

What this PR does / why we need it:
This PR makes sure that allowedCidrs isn't patched on a listener when comparing a list that is out of order.

I noticed this bug due to my second listener never being created when using multiple listeners together with allowedCidrs.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
A part of #1687

Special notes for your reviewer:
I do not know if CompareLists is a good function name. If any other names are preferred just let me know.

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

/hold

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	9e356ad
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65bd040663b85a00076e8110
😎 Deploy Preview	https://deploy-preview-1854--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[k8s-ci-robot]

Hi @huxcrux. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[EmilienM]

/ok-to-test

[EmilienM]

Thanks for your contribution, just add unit tests (example provided) and I think we're good with this nasty bug!

[mdbooth]

/approve

Incidentally I noodled this, which uses the slices package to remove a bunch of boilerplate: shiftstack@e78e77e

You're welcome to use it or not.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huxcrux, mdbooth

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [mdbooth]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dulek]

/lgtm

[huxcrux]

/approve

Incidentally I noodled this, which uses the slices package to remove a bunch of boilerplate: shiftstack@e78e77e

You're welcome to use it or not.

The change looks clean, I'll use it and squash all commits :)

[huxcrux]

@huxcrux: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-cluster-api-provider-openstack-e2e-test 06d940a link true /test pull-cluster-api-provider-openstack-e2e-test
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Created #1857 to push Dockerfile to golang 1.21

This PR needs to be rebased after the linked PR is merged for tests to pass

[mdbooth]

@huxcrux If you would like to apply for membership of kubernetes-sigs I will happily sponsor you. It will mean you can use /lgtm and don't need /ok-to-test.

https://github.com/kubernetes/community/blob/master/community-membership.md

[mdbooth]

/retest-required

[huxcrux]

@huxcrux If you would like to apply for membership of kubernetes-sigs I will happily sponsor you. It will mean you can use /lgtm and don't need /ok-to-test.

https://github.com/kubernetes/community/blob/master/community-membership.md

Looks like it could be a good idea, i'll submit a request later today and add you as one of my sponsors :) thanks in advance

[EmilienM]

@huxcrux If you would like to apply for membership of kubernetes-sigs I will happily sponsor you. It will mean you can use /lgtm and don't need /ok-to-test.
https://github.com/kubernetes/community/blob/master/community-membership.md

Looks like it could be a good idea, i'll submit a request later today and add you as one of my sponsors :) thanks in advance

you can add me too.

[huxcrux]

/unhold

[dulek]

/lgtm

[huxcrux]

/test pull-cluster-api-provider-openstack-e2e-test

[huxcrux]

/test pull-cluster-api-provider-openstack-e2e-test