OpenstackFloatingIPPool: Adds popped ip to claimedIPs #1869

[bilbobrovall]

What this PR does / why we need it:
Adds ip to claimedIPs after it's popped from availableIPs to make sure the same IP is not added from tagged IPs when processing multiple claims in the same reconcile.

Another would be to go back to handling one claim per reconciliation and requeuing to so claimedIPs is always populated from IPAddresses before getIP is called.

Which issue(s) this PR fixes:
Fixes: #1869

Special notes for your reviewer:

1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

TODOs:

• squashed commits
• if necessary:
  • includes documentation
  • adds unit tests

/hold

[netlify]

✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!

Name	Link
🔨 Latest commit	cca2213
🔍 Latest deploy log	https://app.netlify.com/sites/kubernetes-sigs-cluster-api-openstack/deploys/65c3a51539908900087e800f
😎 Deploy Preview	https://deploy-preview-1870--kubernetes-sigs-cluster-api-openstack.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[k8s-ci-robot]

Hi @bilbobrovall. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[huxcrux]

/ok-to-test

[huxcrux]

/lgtm

[dulek]

Seems to make sense to me, if we work sequentially it should help.

Any consideration if we have multiple reconciliation threads? Do we just assume we don't?

[bilbobrovall]

Seems to make sense to me, if we work sequentially it should help.

Any consideration if we have multiple reconciliation threads? Do we just assume we don't?

It was discussed a bit in a previous PR #1763 (comment) and it was concluded that there was nothing to worry about since we have a single reconciler for the pool

[lentzi90]

/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bilbobrovall, lentzi90

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [lentzi90]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[bilbobrovall]

/hold cancel