Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add UserDataSecret into deepcopy file #188

Merged
merged 1 commit into from
Jan 17, 2019

Conversation

yangy2000
Copy link
Contributor

@yangy2000 yangy2000 commented Jan 16, 2019

complete the deepcopy functions

Signed-off-by: Alex Yang yangyang1@zte.com.cn

What this PR does / why we need it:
Run the following commands in pkg/apis/openstackproviderconfig/v1alpha1 directory:

$ go run ../../../../vendor/k8s.io/code-generator/cmd/deepcopy-gen/main.go -O zz_generated.deepcopy -i ./... -h ../../../../hack/boilerplate.go.txt
$ git diff
diff --git a/pkg/apis/openstackproviderconfig/v1alpha1/zz_generated.deepcopy.go b/pkg/apis/openstackproviderconfig/v1alpha1/zz_generated.deepcopy.go
index a95e10d..f9cb99f 100644
--- a/pkg/apis/openstackproviderconfig/v1alpha1/zz_generated.deepcopy.go
+++ b/pkg/apis/openstackproviderconfig/v1alpha1/zz_generated.deepcopy.go
@@ -21,6 +21,7 @@ limitations under the License.
 package v1alpha1

 import (
+       v1 "k8s.io/api/core/v1"
        runtime "k8s.io/apimachinery/pkg/runtime"
 )

@@ -176,6 +177,11 @@ func (in *OpenstackProviderSpec) DeepCopyInto(out *OpenstackProviderSpec) {
                *out = make([]string, len(*in))
                copy(*out, *in)
        }
+       if in.UserDataSecret != nil {
+               in, out := &in.UserDataSecret, &out.UserDataSecret
+               *out = new(v1.SecretReference)
+               **out = **in
+       }
        out.RootVolume = in.RootVolume
        return
 }

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

  1. Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

NONE

Signed-off-by: Alex Yang <yangyang1@zte.com.cn>
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 16, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @yangy2000. Thanks for your PR.

I'm waiting for a kubernetes-sigs or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@flaper87
Copy link
Contributor

/ok-to-test
/approve

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 17, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: flaper87, yangy2000

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 17, 2019
@flaper87
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 17, 2019
@k8s-ci-robot k8s-ci-robot merged commit 3563e73 into kubernetes-sigs:master Jan 17, 2019
flaper87 pushed a commit to flaper87/cluster-api-provider-openstack that referenced this pull request Jan 28, 2019
Signed-off-by: Alex Yang <yangyang1@zte.com.cn>
@yangy2000 yangy2000 deleted the deepocopy branch February 19, 2019 02:14
iamemilio pushed a commit to iamemilio/cluster-api-provider-openstack that referenced this pull request Aug 10, 2021
Bug 1943378: Eliminate instanceCreate volume leak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants