🌱 Fix doc references to NodeCIDR in v1alpha8 #1889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
k8s-ci-robot
added
the
size/M
|
@MaysaMacedo Please can you take a look at this, particularly the new doctext for Subnets? |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/test pull-cluster-api-provider-openstack-test |
huxcrux
reviewed
Feb 19, 2024
config/crd/bases/infrastructure.cluster.x-k8s.io_openstackclusters.yaml
Outdated
Show resolved
Hide resolved
mdbooth
force-pushed
the
nodecidr-docs
branch
from
46a9aac
to
50c6d21
Compare
k8s-ci-robot
removed
the
lgtm
mdbooth
force-pushed
the
nodecidr-docs
branch
from
50c6d21
to
4eec0e7
Compare
|
/lgtm |
k8s-ci-robot
removed
the
do-not-merge/hold
k8s-ci-robot
added
the
lgtm
|
Thank you @mdbooth ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #1887
/hold