test: bump Flatcar version #1936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/XS
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
3 tasks
|
Test is failing because the qemu images looks corrupted 🤷 Trying to generate a new one |
|
/test pull-cluster-api-provider-openstack-e2e-test |
k8s-ci-robot
added
size/M
tormath1
force-pushed
the
tormath1/flatcar
branch
from
61a1e78
to
f55dc21
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lentzi90, tormath1 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
Signed-off-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
This commit sets the provider ID in the flatcar templates. To avoid issues with potential mismatches between node names and openstack servers we can configure the kubelet to set the provider ID. Otherwise, the cloud controller will try to match nodes and servers based on just the name. The names can differ because of special characters, like dots. When this happens, the cloud controller will be unable to match them and thus believe that the node has no underlying server. Co-authored-by: Mathieu Tortuyaux <mtortuyaux@microsoft.com>
tormath1
force-pushed
the
tormath1/flatcar
branch
from
f55dc21
to
957c9fc
Compare
|
Force pushed to fix a typo: https://github.com/kubernetes-sigs/cluster-api-provider-openstack/compare/f55dc21c9d7dff33d15f0ab79c083d3faa543474..957c9fc464331d19e6187233a68a6be2accf2a32 I'm wondering how the CI did pass 🤷 |
|
/unhold |
k8s-ci-robot
removed
the
do-not-merge/hold
|
/lgtm |
k8s-ci-robot
added
the
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Bump the Flatcar major version used by the regular
flatcartemplate tests.Special notes for your reviewer:
containerdshipped as a systemd-sysext image/hold
Closes: #1564