⚠️ Bastion cleanup #1959
⚠️ Bastion cleanup #1959
Conversation
k8s-ci-robot
added
do-not-merge/hold
k8s-ci-robot
added
the
size/L
✅ Deploy Preview for kubernetes-sigs-cluster-api-openstack ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
/lgtm |
k8s-ci-robot
added
the
lgtm
api/v1beta1/types.go
Outdated
| type Bastion struct { | ||
| // Enabled means that bastion is enabled. Defaults to false. | ||
| //+optional |
There was a problem hiding this comment.
Can we make this required with an explicit default of false?
There was a problem hiding this comment.
Thanks for this, I wasn't sure how to approach this.
| Bastion: &infrav1.Bastion{ | ||
| Enabled: true, | ||
| Spec: &instance, | ||
| }, |
There was a problem hiding this comment.
I don't think this test is equivalent. The previous test had: Bastion: &infrav1.Bastion{}, which implied Enabled: false, and we apparently still expect a bastion to be cleaned up in this case. Is that what we were actually testing before? Does it still work that way?
There was a problem hiding this comment.
Okay, I needed to actually fix this with a hack on bastionToInstanceSpec(), where nil .spec will be translated to &OpenStackMachineSpec{}.
This commit works with .spec.bastion: * makes availablityZone, floatingIP and instance pointers * adds floatingIP IPv4 validation * adds validation that if Bastion is enabled, instance cannot be null
Bastion.Spec is way more descriptive and it suggests it's an OpenStackMachineSpec.
k8s-ci-robot
removed
the
lgtm
|
/approve |
k8s-ci-robot
removed
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dulek, mdbooth The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/lgtm |
k8s-ci-robot
added
the
lgtm
What this PR does / why we need it:
This commit works with .spec.bastion:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #
Special notes for your reviewer:
TODOs:
/hold